Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 2627953002: Initialize TaskScheduler in all child processes. (Closed)

Created:
3 years, 11 months ago by fdoray
Modified:
3 years, 11 months ago
Reviewers:
robliao, gab, jam
CC:
chromium-reviews, jam, darin-cc_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize TaskScheduler in all child processes. base::WorkerPool is used in the GPU process (x11_hotplug_event_handler.cc:499). To migrate this call site to TaskScheduler, TaskScheduler must be initialized in the GPU process. base::WorkerPool is also used in PPAPI plugin process (v8_platform.cc:70). BUG=664996 Review-Url: https://codereview.chromium.org/2627953002 Cr-Commit-Position: refs/heads/master@{#444100} Committed: https://chromium.googlesource.com/chromium/src/+/71ee072729403850ee522e08fbd669d3bc2f142f

Patch Set 1 #

Patch Set 2 : GetInstance() #

Patch Set 3 : fix test error #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -35 lines) Patch
M content/child/child_process.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M content/child/child_process.cc View 1 2 4 chunks +20 lines, -0 lines 0 comments Download
M content/renderer/render_process_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_process_impl.cc View 1 2 4 chunks +18 lines, -35 lines 2 comments Download

Depends on Patchset:

Messages

Total messages: 26 (19 generated)
fdoray
PTAL
3 years, 11 months ago (2017-01-13 18:17:40 UTC) #14
gab
lgtm % question https://codereview.chromium.org/2627953002/diff/40001/content/renderer/render_process_impl.cc File content/renderer/render_process_impl.cc (left): https://codereview.chromium.org/2627953002/diff/40001/content/renderer/render_process_impl.cc#oldcode131 content/renderer/render_process_impl.cc:131: switches::kSingleProcess)) { No longer care about ...
3 years, 11 months ago (2017-01-13 23:39:57 UTC) #15
fdoray
https://codereview.chromium.org/2627953002/diff/40001/content/renderer/render_process_impl.cc File content/renderer/render_process_impl.cc (left): https://codereview.chromium.org/2627953002/diff/40001/content/renderer/render_process_impl.cc#oldcode131 content/renderer/render_process_impl.cc:131: switches::kSingleProcess)) { On 2017/01/13 23:39:57, gab wrote: > No ...
3 years, 11 months ago (2017-01-15 14:11:27 UTC) #16
fdoray
PTAL
3 years, 11 months ago (2017-01-15 14:15:19 UTC) #19
jam
lgtm
3 years, 11 months ago (2017-01-17 16:47:36 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627953002/40001
3 years, 11 months ago (2017-01-17 17:24:21 UTC) #23
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 18:51:12 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/71ee072729403850ee522e08fbd6...

Powered by Google App Engine
This is Rietveld 408576698