Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Issue 2626783002: Remove old APIs from components/task_scheduler_util/. (Closed)

Created:
3 years, 11 months ago by fdoray
Modified:
3 years, 9 months ago
CC:
blundell+watchlist_chromium.org, chromium-reviews, droger+watchlist_chromium.org, gab, marq+watch_chromium.org, noyau+watch_chromium.org, pkl (ping after 24h if needed), sdefresne+watchlist_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove old APIs from components/task_scheduler_util/. Old functions were kept because they were used by ios_internal. Now that the relevant ios_internal code has been upstreamed, it is easy to remove the old functions and their call sites. BUG=664996 Review-Url: https://codereview.chromium.org/2626783002 Cr-Commit-Position: refs/heads/master@{#443597} Committed: https://chromium.googlesource.com/chromium/src/+/1dd2123f95a214c34887df33b27e46114b3d3fe4

Patch Set 1 #

Patch Set 2 : fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -333 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +5 lines, -8 lines 0 comments Download
M components/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D components/task_scheduler_util/initialization/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D components/task_scheduler_util/initialization/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/task_scheduler_util/initialization/browser_util.h View 1 chunk +0 lines, -29 lines 0 comments Download
D components/task_scheduler_util/initialization/browser_util.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D components/task_scheduler_util/variations/BUILD.gn View 1 chunk +0 lines, -28 lines 0 comments Download
D components/task_scheduler_util/variations/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/task_scheduler_util/variations/browser_variations_util.h View 1 chunk +0 lines, -31 lines 0 comments Download
D components/task_scheduler_util/variations/browser_variations_util.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D components/task_scheduler_util/variations/browser_variations_util_unittest.cc View 1 chunk +0 lines, -155 lines 0 comments Download
M ios/chrome/browser/web/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M ios/chrome/browser/web/chrome_web_client.mm View 1 2 chunks +6 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 29 (17 generated)
fdoray
PTAL
3 years, 11 months ago (2017-01-11 15:26:10 UTC) #8
gab
Cool, deferring to robliao@
3 years, 11 months ago (2017-01-12 19:27:35 UTC) #12
robliao
lgtm Also verified builds with iOS.
3 years, 11 months ago (2017-01-12 23:46:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626783002/20001
3 years, 11 months ago (2017-01-13 13:05:39 UTC) #15
fdoray
eugenebut@: Please review changes in /ios/chrome/browser/web/*
3 years, 11 months ago (2017-01-13 13:08:15 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/341593)
3 years, 11 months ago (2017-01-13 13:12:03 UTC) #19
fdoray
eugenebut@: Please review changes in /ios/chrome/browser/web/*
3 years, 11 months ago (2017-01-13 13:16:39 UTC) #20
Eugene But (OOO till 7-30)
ios lgtm
3 years, 11 months ago (2017-01-13 16:28:43 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626783002/20001
3 years, 11 months ago (2017-01-13 16:41:45 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/1dd2123f95a214c34887df33b27e46114b3d3fe4
3 years, 11 months ago (2017-01-13 17:38:46 UTC) #26
Wez
Hallo jochen@chromium.org! Due to a depot_tools patch which mistakenly removed the OWNERS check for non-source ...
3 years, 10 months ago (2017-02-07 19:50:39 UTC) #28
jochen (gone - plz use gerrit)
3 years, 9 months ago (2017-03-21 21:23:00 UTC) #29
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698