Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1454)

Issue 2627933002: Removing logic on showing/hiding separator (Closed)

Created:
3 years, 11 months ago by bruthig
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Removing logic on showing/hiding separator Since |logout_button_tray_| is moved to the left most position in the status area widget, the logic on hiding separator of tray in left of the |logout_button_tray_| is no longer needed because there is no such tray. (confirmed with @sgabriel that |logout_button_tray_| will always be the left most one). Note that this is a partial revert of code added in https://codereview.chromium.org/2147143002/. BUG=657211 Review-Url: https://codereview.chromium.org/2582923002 Cr-Commit-Position: refs/heads/master@{#439398} (cherry picked from commit 26f5083f295844743f7e7510ba5fba5680368057) Review-Url: https://codereview.chromium.org/2627933002 . Cr-Commit-Position: refs/branch-heads/2924@{#729} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/4b51a93a49348dd8535737826dcef052d898cfbc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -68 lines) Patch
M ash/common/system/status_area_widget.h View 3 chunks +0 lines, -11 lines 0 comments Download
M ash/common/system/status_area_widget.cc View 2 chunks +0 lines, -40 lines 0 comments Download
M ash/common/system/tray/tray_background_view.h View 2 chunks +0 lines, -7 lines 0 comments Download
M ash/common/system/tray/tray_background_view.cc View 5 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bruthig
3 years, 11 months ago (2017-01-11 15:09:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4b51a93a49348dd8535737826dcef052d898cfbc.

Powered by Google App Engine
This is Rietveld 408576698