Removing logic on showing/hiding separator

Removing logic on showing/hiding separator

Since |logout_button_tray_| is moved to the left most position
in the status area widget, the logic on hiding separator of tray
in left of the |logout_button_tray_| is no longer needed because
there is no such tray. (confirmed with @sgabriel that
|logout_button_tray_| will always be the left most one).

Note that this is a partial revert of code added in
https://codereview.chromium.org/2147143002/.

BUG=657211
Committed: https://crrev.com/26f5083f295844743f7e7510ba5fba5680368057
Cr-Commit-Position: refs/heads/master@{#439398}

[yiyix, 2016-12-17 00:54:39]

Patchset #1 (id:1) has been deleted

[yiyix, 2016-12-17 01:03:29]

Description was changed from

==========
remove separator logics

BUG=657211
==========

to

==========
Removing logic on showing/hiding separator

Since |logout_button_tray_| is moved to the left most position in the status
area widget, the logic on hiding separator of tray in left of the
|logout_button_tray_| is no longer needed because there is no such tray.
(confirmed with @sgabriel that |logout_button_tray_| will always be on the left
most side)

BUG=657211
==========

[yiyix, 2016-12-17 01:03:36]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[yiyix, 2016-12-17 01:03:48]

yiyix@chromium.org changed reviewers:
+ jamescook@chromium.org

[commit-bot: I haz the power, 2016-12-17 01:04:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yiyix, 2016-12-17 01:05:48]

Description was changed from

==========
Removing logic on showing/hiding separator

Since |logout_button_tray_| is moved to the left most position in the status
area widget, the logic on hiding separator of tray in left of the
|logout_button_tray_| is no longer needed because there is no such tray.
(confirmed with @sgabriel that |logout_button_tray_| will always be on the left
most side)

BUG=657211
==========

to

==========
Removing logic on showing/hiding separator

Since |logout_button_tray_| is moved to the left most position 
in the status area widget, the logic on hiding separator of tray 
in left of the |logout_button_tray_| is no longer needed because 
there is no such tray. (confirmed with @sgabriel that 
|logout_button_tray_| will always be on the left most side)

BUG=657211
==========

[yiyix, 2016-12-17 01:06:14]

@jamescook, could you please take a look at this change? Thank you very much

[yiyix, 2016-12-17 01:06:14]

@jamescook, could you please take a look at this change? Thank you very much

[commit-bot: I haz the power, 2016-12-17 01:46:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-17 01:46:33]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-12-17 18:32:39]

LGTM. Hooray for less code!

nit: When removing code like this consider referencing the change that added it
in the CL description. For example, I might add:

"This is a partial revert of code added in
https://codereview.chromium.org/2147143002/."

That helps the reviewer see which pieces you are backing out.

[yiyix, 2016-12-18 19:55:23]

Description was changed from

==========
Removing logic on showing/hiding separator

Since |logout_button_tray_| is moved to the left most position 
in the status area widget, the logic on hiding separator of tray 
in left of the |logout_button_tray_| is no longer needed because 
there is no such tray. (confirmed with @sgabriel that 
|logout_button_tray_| will always be on the left most side)

BUG=657211
==========

to

==========
Removing logic on showing/hiding separator

Since |logout_button_tray_| is moved to the left most position 
in the status area widget, the logic on hiding separator of tray 
in left of the |logout_button_tray_| is no longer needed because 
there is no such tray. (confirmed with @sgabriel that 
|logout_button_tray_| will always be the left most one)

BUG=657211
==========

[yiyix, 2016-12-19 03:19:38]

Description was changed from

==========
Removing logic on showing/hiding separator

Since |logout_button_tray_| is moved to the left most position 
in the status area widget, the logic on hiding separator of tray 
in left of the |logout_button_tray_| is no longer needed because 
there is no such tray. (confirmed with @sgabriel that 
|logout_button_tray_| will always be the left most one)

BUG=657211
==========

to

==========
Removing logic on showing/hiding separator

Since |logout_button_tray_| is moved to the left most position 
in the status area widget, the logic on hiding separator of tray 
in left of the |logout_button_tray_| is no longer needed because 
there is no such tray. (confirmed with @sgabriel that 
|logout_button_tray_| will always be the left most one).

Note that this is a partial revert of code added in
https://codereview.chromium.org/2147143002/.

BUG=657211
==========

[yiyix, 2016-12-19 03:20:18]

On 2016/12/17 18:32:39, James Cook wrote:
> LGTM. Hooray for less code!
> 
> nit: When removing code like this consider referencing the change that added
it
> in the CL description. For example, I might add:
> 
> "This is a partial revert of code added in
> https://codereview.chromium.org/2147143002/.%22
> 
> That helps the reviewer see which pieces you are backing out.

Thank you for the fast review~! I am really happy of this design decision as
well. 

Description updated.

[yiyix, 2016-12-19 03:20:43]

The CQ bit was checked by yiyix@chromium.org

[commit-bot: I haz the power, 2016-12-19 03:20:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 03:47:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482117643445060,
"parent_rev": "6ea4a67eca49b1fee343acec002b8cb0235bf665", "commit_rev":
"f7accb389d0e6612eab82bc15b7f6c46c591ac34"}

[commit-bot: I haz the power, 2016-12-19 03:47:31]

Description was changed from

==========
Removing logic on showing/hiding separator

Since |logout_button_tray_| is moved to the left most position 
in the status area widget, the logic on hiding separator of tray 
in left of the |logout_button_tray_| is no longer needed because 
there is no such tray. (confirmed with @sgabriel that 
|logout_button_tray_| will always be the left most one).

Note that this is a partial revert of code added in
https://codereview.chromium.org/2147143002/.

BUG=657211
==========

to

==========
Removing logic on showing/hiding separator

Since |logout_button_tray_| is moved to the left most position 
in the status area widget, the logic on hiding separator of tray 
in left of the |logout_button_tray_| is no longer needed because 
there is no such tray. (confirmed with @sgabriel that 
|logout_button_tray_| will always be the left most one).

Note that this is a partial revert of code added in
https://codereview.chromium.org/2147143002/.

BUG=657211

Review-Url: https://codereview.chromium.org/2582923002
==========

[commit-bot: I haz the power, 2016-12-19 03:47:32]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-12-19 03:49:03]

Description was changed from

==========
Removing logic on showing/hiding separator

Since |logout_button_tray_| is moved to the left most position 
in the status area widget, the logic on hiding separator of tray 
in left of the |logout_button_tray_| is no longer needed because 
there is no such tray. (confirmed with @sgabriel that 
|logout_button_tray_| will always be the left most one).

Note that this is a partial revert of code added in
https://codereview.chromium.org/2147143002/.

BUG=657211

Review-Url: https://codereview.chromium.org/2582923002
==========

to

==========
Removing logic on showing/hiding separator

Since |logout_button_tray_| is moved to the left most position
in the status area widget, the logic on hiding separator of tray
in left of the |logout_button_tray_| is no longer needed because
there is no such tray. (confirmed with @sgabriel that
|logout_button_tray_| will always be the left most one).

Note that this is a partial revert of code added in
https://codereview.chromium.org/2147143002/.

BUG=657211

Committed: https://crrev.com/26f5083f295844743f7e7510ba5fba5680368057
Cr-Commit-Position: refs/heads/master@{#439398}
==========

[commit-bot: I haz the power, 2016-12-19 03:49:04]

Patchset 1 (id:??) landed as
https://crrev.com/26f5083f295844743f7e7510ba5fba5680368057
Cr-Commit-Position: refs/heads/master@{#439398}