Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 2627893003: Revert of [wasm][asm.js] Enable --validate-asm by default. (Closed)

Created:
3 years, 11 months ago by bradnelson
Modified:
3 years, 11 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm][asm.js] Enable --validate-asm by default. (patchset #2 id:20001 of https://codereview.chromium.org/2624813002/ ) Reason for revert: Triggers flaky tests. Original issue's description: > [wasm][asm.js] Enable --validate-asm by default. > > This directs all asm.js traffic via the Wasm backend. > > R=titzer@chromium.org,aseemgarg@chromium.org > BUG=v8:4203 > > Review-Url: https://codereview.chromium.org/2624813002 > Cr-Original-Commit-Position: refs/heads/master@{#42194} > Committed: https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652562ad > Review-Url: https://codereview.chromium.org/2624813002 > Cr-Commit-Position: refs/heads/master@{#42244} > Committed: https://chromium.googlesource.com/v8/v8/+/3169fb94c98953f002908974a606b51a35178046 TBR=aseemgarg@chromium.org,titzer@chromium.org,bradnelson@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4203 Review-Url: https://codereview.chromium.org/2627893003 Cr-Commit-Position: refs/heads/master@{#42253} Committed: https://chromium.googlesource.com/v8/v8/+/d11da92f43f1f96981cb823ea2d2c9aa23a64176

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
bradnelson
Created Revert of [wasm][asm.js] Enable --validate-asm by default.
3 years, 11 months ago (2017-01-12 02:00:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627893003/1
3 years, 11 months ago (2017-01-12 02:00:31 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 02:00:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d11da92f43f1f96981cb823ea2d2c9aa23a...

Powered by Google App Engine
This is Rietveld 408576698