Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2624813002:
[wasm][asm.js] Enable --validate-asm by default. (Closed)
|
Created:
3 years, 11 months ago by bradnelson Modified:
3 years, 11 months ago CC:
v8-reviews_googlegroups.com, Michael Hablich Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[wasm][asm.js] Enable --validate-asm by default.
This directs all asm.js traffic via the Wasm backend.
Make asm.js console output less noisy.
R=titzer@chromium.org,aseemgarg@chromium.org
BUG=v8:4203
Review-Url: https://codereview.chromium.org/2624813002
Cr-Original-Original-Commit-Position: refs/heads/master@{#42194}
Committed: https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652562ad
Review-Url: https://codereview.chromium.org/2624813002
Cr-Original-Commit-Position: refs/heads/master@{#42244}
Committed: https://chromium.googlesource.com/v8/v8/+/3169fb94c98953f002908974a606b51a35178046
Review-Url: https://codereview.chromium.org/2624813002
Cr-Commit-Position: refs/heads/master@{#42300}
Committed: https://chromium.googlesource.com/v8/v8/+/f6929084821d4f021b2c2768c9856472ffa42623
Patch Set 1 #Patch Set 2 : reland #Patch Set 3 : fix #
Messages
Total messages: 40 (25 generated)
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
bradnelson@google.com changed reviewers: + bradnelson@google.com
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by bradnelson@google.com
The CQ bit was checked by bradnelson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1484074183888670, "parent_rev":
"4c699e349a4986b28574b3a51e8780e3a3d067b1", "commit_rev":
"946cc371ed4b34d1a9f5cc615b14c41b652562ad"}
Message was sent while issue was closed.
Description was changed from ========== [wasm][asm.js] Enable --validate-asm by default. This directs all asm.js traffic via the Wasm backend. R=titzer@chromium.org,aseemgarg@chromium.org BUG=v8:4203 ========== to ========== [wasm][asm.js] Enable --validate-asm by default. This directs all asm.js traffic via the Wasm backend. R=titzer@chromium.org,aseemgarg@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2624813002 Cr-Commit-Position: refs/heads/master@{#42194} Committed: https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2622023002/ by machenbach@chromium.org. The reason for reverting is: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui... See also: https://github.com/v8/v8/wiki/Blink%20layout%20tests.
Message was sent while issue was closed.
Attempting to reland.
Message was sent while issue was closed.
Description was changed from ========== [wasm][asm.js] Enable --validate-asm by default. This directs all asm.js traffic via the Wasm backend. R=titzer@chromium.org,aseemgarg@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2624813002 Cr-Commit-Position: refs/heads/master@{#42194} Committed: https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652... ========== to ========== [wasm][asm.js] Enable --validate-asm by default. This directs all asm.js traffic via the Wasm backend. R=titzer@chromium.org,aseemgarg@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2624813002 Cr-Commit-Position: refs/heads/master@{#42194} Committed: https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652... ==========
The CQ bit was checked by bradnelson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org Link to the patchset: https://codereview.chromium.org/2624813002/#ps20001 (title: "reland")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Have turned off success messages for asm.js (should fix layout test issue).
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484156777496030,
"parent_rev": "45938454177f53fa24cfc08ad97ccbc162c3ba6d", "commit_rev":
"3169fb94c98953f002908974a606b51a35178046"}
Message was sent while issue was closed.
Description was changed from ========== [wasm][asm.js] Enable --validate-asm by default. This directs all asm.js traffic via the Wasm backend. R=titzer@chromium.org,aseemgarg@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2624813002 Cr-Commit-Position: refs/heads/master@{#42194} Committed: https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652... ========== to ========== [wasm][asm.js] Enable --validate-asm by default. This directs all asm.js traffic via the Wasm backend. R=titzer@chromium.org,aseemgarg@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2624813002 Cr-Original-Commit-Position: refs/heads/master@{#42194} Committed: https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652... Review-Url: https://codereview.chromium.org/2624813002 Cr-Commit-Position: refs/heads/master@{#42244} Committed: https://chromium.googlesource.com/v8/v8/+/3169fb94c98953f002908974a606b51a351... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/3169fb94c98953f002908974a606b51a351...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2627893003/ by bradnelson@chromium.org. The reason for reverting is: Triggers flaky tests..
Message was sent while issue was closed.
Description was changed from ========== [wasm][asm.js] Enable --validate-asm by default. This directs all asm.js traffic via the Wasm backend. R=titzer@chromium.org,aseemgarg@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2624813002 Cr-Original-Commit-Position: refs/heads/master@{#42194} Committed: https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652... Review-Url: https://codereview.chromium.org/2624813002 Cr-Commit-Position: refs/heads/master@{#42244} Committed: https://chromium.googlesource.com/v8/v8/+/3169fb94c98953f002908974a606b51a351... ========== to ========== [wasm][asm.js] Enable --validate-asm by default. This directs all asm.js traffic via the Wasm backend. R=titzer@chromium.org,aseemgarg@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2624813002 Cr-Original-Commit-Position: refs/heads/master@{#42194} Committed: https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652... Review-Url: https://codereview.chromium.org/2624813002 Cr-Commit-Position: refs/heads/master@{#42244} Committed: https://chromium.googlesource.com/v8/v8/+/3169fb94c98953f002908974a606b51a351... ==========
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [wasm][asm.js] Enable --validate-asm by default. This directs all asm.js traffic via the Wasm backend. R=titzer@chromium.org,aseemgarg@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2624813002 Cr-Original-Commit-Position: refs/heads/master@{#42194} Committed: https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652... Review-Url: https://codereview.chromium.org/2624813002 Cr-Commit-Position: refs/heads/master@{#42244} Committed: https://chromium.googlesource.com/v8/v8/+/3169fb94c98953f002908974a606b51a351... ========== to ========== [wasm][asm.js] Enable --validate-asm by default. This directs all asm.js traffic via the Wasm backend. Make asm.js console output less noisy. R=titzer@chromium.org,aseemgarg@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2624813002 Cr-Original-Commit-Position: refs/heads/master@{#42194} Committed: https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652... Review-Url: https://codereview.chromium.org/2624813002 Cr-Commit-Position: refs/heads/master@{#42244} Committed: https://chromium.googlesource.com/v8/v8/+/3169fb94c98953f002908974a606b51a351... ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bradnelson@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org Link to the patchset: https://codereview.chromium.org/2624813002/#ps40001 (title: "fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Failure before seemed unrelated. Now unable to repro on bots with this patch applied.
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484274242531610,
"parent_rev": "f488a412962ac8871c2707294b6190001feaa44d", "commit_rev":
"f6929084821d4f021b2c2768c9856472ffa42623"}
Message was sent while issue was closed.
Description was changed from ========== [wasm][asm.js] Enable --validate-asm by default. This directs all asm.js traffic via the Wasm backend. Make asm.js console output less noisy. R=titzer@chromium.org,aseemgarg@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2624813002 Cr-Original-Commit-Position: refs/heads/master@{#42194} Committed: https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652... Review-Url: https://codereview.chromium.org/2624813002 Cr-Commit-Position: refs/heads/master@{#42244} Committed: https://chromium.googlesource.com/v8/v8/+/3169fb94c98953f002908974a606b51a351... ========== to ========== [wasm][asm.js] Enable --validate-asm by default. This directs all asm.js traffic via the Wasm backend. Make asm.js console output less noisy. R=titzer@chromium.org,aseemgarg@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2624813002 Cr-Original-Original-Commit-Position: refs/heads/master@{#42194} Committed: https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652... Review-Url: https://codereview.chromium.org/2624813002 Cr-Original-Commit-Position: refs/heads/master@{#42244} Committed: https://chromium.googlesource.com/v8/v8/+/3169fb94c98953f002908974a606b51a351... Review-Url: https://codereview.chromium.org/2624813002 Cr-Commit-Position: refs/heads/master@{#42300} Committed: https://chromium.googlesource.com/v8/v8/+/f6929084821d4f021b2c2768c9856472ffa... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/f6929084821d4f021b2c2768c9856472ffa...
Message was sent while issue was closed.
Do we need to pass something special to switch --validate-asm off with fullcode?
Message was sent while issue was closed.
On 2017/01/13 11:23:30, Michael Achenbach wrote: > Do we need to pass something special to switch --validate-asm off with fullcode? In particularly, here: https://cs.chromium.org/chromium/src/v8/tools/foozzie/v8_foozzie.py?q=v8_fooz... Does fullcode now make a difference to ignition_staging when comparing (in regards to asm)? If not, we'd maybe need to pass an extra flag to the follcode version? |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
