Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2627833003: Revert of Made text-align property independent. (Closed)

Created:
3 years, 11 months ago by napper
Modified:
3 years, 11 months ago
Reviewers:
sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Made text-align property independent. (patchset #2 id:20001 of https://codereview.chromium.org/2628503002/ ) Reason for revert: Misaligned text elements found in manual testing. BUG=680009 Original issue's description: > Made text-align property independent. > > Made text-align property independent. Also updated > independent-inheritance-fast-path.html to include textAlign. > > Tested using independent-inheritance-fast-path.html. > > BUG=628043 > > Review-Url: https://codereview.chromium.org/2628503002 > Cr-Commit-Position: refs/heads/master@{#442500} > Committed: https://chromium.googlesource.com/chromium/src/+/d8b62ea53246ab528786b9a8d312d0a3733e46e9 TBR=sashab@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=628043 Review-Url: https://codereview.chromium.org/2627833003 Cr-Commit-Position: refs/heads/master@{#443101} Committed: https://chromium.googlesource.com/chromium/src/+/19df4a657a408440594776000848d096feffe5d7

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (13 generated)
napper
Created Revert of Made text-align property independent.
3 years, 11 months ago (2017-01-11 22:29:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627833003/1
3 years, 11 months ago (2017-01-11 22:31:05 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-11 22:31:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627833003/1
3 years, 11 months ago (2017-01-11 22:40:20 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-11 22:40:22 UTC) #10
sashab
lgtm
3 years, 11 months ago (2017-01-11 22:42:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627833003/1
3 years, 11 months ago (2017-01-11 22:43:54 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/192050) android_cronet on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 11 months ago (2017-01-11 22:49:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627833003/70001
3 years, 11 months ago (2017-01-11 23:04:37 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 01:10:28 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:70001) as
https://chromium.googlesource.com/chromium/src/+/19df4a657a408440594776000848...

Powered by Google App Engine
This is Rietveld 408576698