Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2628503002: Made text-align property independent. (Closed)

Created:
3 years, 11 months ago by napper
Modified:
3 years, 11 months ago
Reviewers:
sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made text-align property independent. Made text-align property independent. Also updated independent-inheritance-fast-path.html to include textAlign. Tested using independent-inheritance-fast-path.html. BUG=628043 Review-Url: https://codereview.chromium.org/2628503002 Cr-Commit-Position: refs/heads/master@{#442500} Committed: https://chromium.googlesource.com/chromium/src/+/d8b62ea53246ab528786b9a8d312d0a3733e46e9

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added trailing comma to textAlign entry in independent_properties. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (13 generated)
napper
3 years, 11 months ago (2017-01-10 01:42:49 UTC) #4
sashab
Yayy!! Welcome back :) https://codereview.chromium.org/2628503002/diff/1/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html File third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html (right): https://codereview.chromium.org/2628503002/diff/1/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html#newcode24 third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html:24: ["textAlign", "start", "left"] Add trailing ...
3 years, 11 months ago (2017-01-10 01:45:27 UTC) #5
sashab
Oops also LGTM :)
3 years, 11 months ago (2017-01-10 01:45:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628503002/20001
3 years, 11 months ago (2017-01-10 01:58:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 11 months ago (2017-01-10 04:00:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628503002/20001
3 years, 11 months ago (2017-01-10 05:29:13 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/d8b62ea53246ab528786b9a8d312d0a3733e46e9
3 years, 11 months ago (2017-01-10 05:44:30 UTC) #20
napper
3 years, 11 months ago (2017-01-11 22:29:54 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2627833003/ by napper@chromium.org.

The reason for reverting is: Misaligned text elements found in manual testing.

BUG=680009.

Powered by Google App Engine
This is Rietveld 408576698