Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2627723007: [wasm] Exporting i64 globals causes a link error. (Closed)

Created:
3 years, 11 months ago by ahaas
Modified:
3 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Exporting i64 globals causes a link error. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2627723007 Cr-Commit-Position: refs/heads/master@{#42333} Committed: https://chromium.googlesource.com/v8/v8/+/a6fe748d5346a39994c80bc99bbfb5526a9a0319

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M src/wasm/wasm-module.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/globals.js View 1 chunk +11 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
ahaas
3 years, 11 months ago (2017-01-13 14:01:53 UTC) #1
titzer
lgtm
3 years, 11 months ago (2017-01-13 14:15:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627723007/1
3 years, 11 months ago (2017-01-13 14:37:02 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 14:38:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a6fe748d5346a39994c80bc99bbfb5526a9...

Powered by Google App Engine
This is Rietveld 408576698