Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: src/wasm/wasm-module.cc

Issue 2627723007: [wasm] Exporting i64 globals causes a link error. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/wasm/globals.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <memory> 5 #include <memory>
6 6
7 #include "src/assembler-inl.h" 7 #include "src/assembler-inl.h"
8 #include "src/base/adapters.h" 8 #include "src/base/adapters.h"
9 #include "src/base/atomic-utils.h" 9 #include "src/base/atomic-utils.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1905 matching lines...) Expand 10 before | Expand all | Expand 10 after
1916 switch (global.type) { 1916 switch (global.type) {
1917 case kWasmI32: 1917 case kWasmI32:
1918 num = *GetRawGlobalPtr<int32_t>(global); 1918 num = *GetRawGlobalPtr<int32_t>(global);
1919 break; 1919 break;
1920 case kWasmF32: 1920 case kWasmF32:
1921 num = *GetRawGlobalPtr<float>(global); 1921 num = *GetRawGlobalPtr<float>(global);
1922 break; 1922 break;
1923 case kWasmF64: 1923 case kWasmF64:
1924 num = *GetRawGlobalPtr<double>(global); 1924 num = *GetRawGlobalPtr<double>(global);
1925 break; 1925 break;
1926 case kWasmI64:
1927 thrower_->LinkError(
1928 "export of globals of type I64 is not allowed.");
1929 break;
1926 default: 1930 default:
1927 UNREACHABLE(); 1931 UNREACHABLE();
1928 } 1932 }
1929 desc.set_value(isolate_->factory()->NewNumber(num)); 1933 desc.set_value(isolate_->factory()->NewNumber(num));
1930 break; 1934 break;
1931 } 1935 }
1932 default: 1936 default:
1933 UNREACHABLE(); 1937 UNREACHABLE();
1934 break; 1938 break;
1935 } 1939 }
(...skipping 566 matching lines...) Expand 10 before | Expand all | Expand 10 after
2502 2506
2503 JSObject::AddProperty(entry, name_string, export_name.ToHandleChecked(), 2507 JSObject::AddProperty(entry, name_string, export_name.ToHandleChecked(),
2504 NONE); 2508 NONE);
2505 JSObject::AddProperty(entry, kind_string, export_kind, NONE); 2509 JSObject::AddProperty(entry, kind_string, export_kind, NONE);
2506 2510
2507 storage->set(index, *entry); 2511 storage->set(index, *entry);
2508 } 2512 }
2509 2513
2510 return array_object; 2514 return array_object;
2511 } 2515 }
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/wasm/globals.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698