Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 2627713008: Revert of Pull define for version out into v8-version.h and separate build target (Closed)

Created:
3 years, 11 months ago by Michael Hablich
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Pull define for version out into v8-version.h and separate build target (patchset #1 id:1 of https://codereview.chromium.org/2621983002/ ) Reason for revert: Blocks roll: https://codereview.chromium.org/2633463002/ Original issue's description: > Pull define for version out into v8-version.h and separate build target > > This is part of removing the dependency of the Chromium browser DLL on > Windows on V8. > > R=jochen@chromium.org > BUG=chromium:581766 > > Review-Url: https://codereview.chromium.org/2621983002 > Cr-Commit-Position: refs/heads/master@{#42243} > Committed: https://chromium.googlesource.com/v8/v8/+/45938454177f53fa24cfc08ad97ccbc162c3ba6d TBR=jochen@chromium.org,machenbach@chromium.org,scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:581766 Review-Url: https://codereview.chromium.org/2627713008 Cr-Commit-Position: refs/heads/master@{#42257} Committed: https://chromium.googlesource.com/v8/v8/+/1adc70b0f9573ddd75d4094383fad1b033628da4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -32 lines) Patch
M BUILD.gn View 3 chunks +1 line, -11 lines 0 comments Download
M include/v8-version.h View 1 chunk +0 lines, -20 lines 0 comments Download
M src/version.cc View 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Hablich
Created Revert of Pull define for version out into v8-version.h and separate build target
3 years, 11 months ago (2017-01-12 09:26:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627713008/1
3 years, 11 months ago (2017-01-12 09:26:41 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 09:26:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1adc70b0f9573ddd75d4094383fad1b0336...

Powered by Google App Engine
This is Rietveld 408576698