Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: include/v8-version.h

Issue 2627713008: Revert of Pull define for version out into v8-version.h and separate build target (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | src/version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8-version.h
diff --git a/include/v8-version.h b/include/v8-version.h
index e963b34d07dae243f056b158aa3dfb89028cd622..a7a9a2f7bdcee5fdadf0d5dde5bf0724f78e885d 100644
--- a/include/v8-version.h
+++ b/include/v8-version.h
@@ -17,24 +17,4 @@
// (Boolean macro values are not supported by all preprocessors.)
#define V8_IS_CANDIDATE_VERSION 1
-#if V8_IS_CANDIDATE_VERSION
-#define V8_CANDIDATE_STRING " (candidate)"
-#else
-#define V8_CANDIDATE_STRING ""
-#endif
-
-#define V8_SX(x) #x
-#define V8_S(x) V8_SX(x)
-
-#if V8_PATCH_LEVEL > 0
-#define V8_VERSION_STRING \
- V8_S(V8_MAJOR_VERSION) \
- "." V8_S(V8_MINOR_VERSION) "." V8_S(V8_BUILD_NUMBER) "." V8_S( \
- V8_PATCH_LEVEL) V8_CANDIDATE_STRING
-#else
-#define V8_VERSION_STRING \
- V8_S(V8_MAJOR_VERSION) \
- "." V8_S(V8_MINOR_VERSION) "." V8_S(V8_BUILD_NUMBER) V8_CANDIDATE_STRING
-#endif
-
#endif // V8_INCLUDE_VERSION_H_
« no previous file with comments | « BUILD.gn ('k') | src/version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698