Move constructor for base::FilePath

Move constructor for base::FilePath

R=danakj@chromium.org
BUG=670043
Review-Url: https://codereview.chromium.org/2627713002
Cr-Commit-Position: refs/heads/master@{#443129}
Committed: https://chromium.googlesource.com/chromium/src/+/590f8e6768702a8172c67b3cda7745107b6b1e0d

[dmurph, 2017-01-10 22:43:46]

Hello Dana!

This implements the move constructor for base::FilePath. WDYT?

Daniel

[danakj, 2017-01-11 16:08:36]

LGTM

https://codereview.chromium.org/2627713002/diff/1/base/files/file_path.h
File base/files/file_path.h (right):

https://codereview.chromium.org/2627713002/diff/1/base/files/file_path.h#newc...
base/files/file_path.h:181: FilePath(FilePath&& that);
Can you drop a comment that |that| is left in an valid but unspecified state
(since std::string does so)?

https://codereview.chromium.org/2627713002/diff/1/base/files/file_path.h#newc...
base/files/file_path.h:185: FilePath& operator=(FilePath&& that);
same

[dmurph, 2017-01-11 20:07:55]

The added comments made it seem a bit cluttered, so I moved the constructor and
operator out on their own. How does that look?

https://codereview.chromium.org/2627713002/diff/1/base/files/file_path.h
File base/files/file_path.h (right):

https://codereview.chromium.org/2627713002/diff/1/base/files/file_path.h#newc...
base/files/file_path.h:181: FilePath(FilePath&& that);
On 2017/01/11 16:08:36, danakj (slow) wrote:
> Can you drop a comment that |that| is left in an valid but unspecified state
> (since std::string does so)?

Done.

https://codereview.chromium.org/2627713002/diff/1/base/files/file_path.h#newc...
base/files/file_path.h:185: FilePath& operator=(FilePath&& that);
On 2017/01/11 16:08:36, danakj (slow) wrote:
> same

Done.

[dmurph, 2017-01-11 20:08:03]

The CQ bit was checked by dmurph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 20:08:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-01-11 20:13:59]

LGTM

[dmurph, 2017-01-11 20:20:27]

The CQ bit was unchecked by dmurph@chromium.org

[dmurph, 2017-01-11 20:20:33]

The CQ bit was checked by dmurph@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:20:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 20:41:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:41:14]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dmurph, 2017-01-12 00:27:50]

The CQ bit was checked by dmurph@chromium.org

[commit-bot: I haz the power, 2017-01-12 00:28:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 02:54:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484180870677720,
"parent_rev": "5d0bae6b0cf3d23a1b4d6a56e34ed015cfa82989", "commit_rev":
"590f8e6768702a8172c67b3cda7745107b6b1e0d"}

[commit-bot: I haz the power, 2017-01-12 02:54:45]

Description was changed from

==========
Move constructor for base::FilePath

R=danakj@chromium.org
BUG=670043
==========

to

==========
Move constructor for base::FilePath

R=danakj@chromium.org
BUG=670043

Review-Url: https://codereview.chromium.org/2627713002
Cr-Commit-Position: refs/heads/master@{#443129}
Committed:
https://chromium.googlesource.com/chromium/src/+/590f8e6768702a8172c67b3cda77...
==========

[commit-bot: I haz the power, 2017-01-12 02:54:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/590f8e6768702a8172c67b3cda77...