Move constructor for base::FilePath

base/files/file_path.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // FilePath is a container for pathnames stored in a platform's native string
 // type, providing containers for manipulation in according with the
 // platform's conventions for pathnames.  It supports the following path
 // types:
 //
 //                   POSIX            Windows
@@ skipping 160 matching lines @@
   static const CharType kCurrentDirectory[];
 
   // A special path component meaning "the parent directory."
   static const CharType kParentDirectory[];
 
   // The character used to identify a file extension.
   static const CharType kExtensionSeparator;
 
   FilePath();
   FilePath(const FilePath& that);
+  FilePath(FilePath&& that);

[danakj, 2017/01/11 16:08:36]

Can you drop a comment that |that| is left in an valid but unspecified state
(since std::string does so)?

[dmurph, 2017/01/11 20:07:55]

Done.

   explicit FilePath(StringPieceType path);
   ~FilePath();
   FilePath& operator=(const FilePath& that);
+  FilePath& operator=(FilePath&& that);

[danakj, 2017/01/11 16:08:36]

same

[dmurph, 2017/01/11 20:07:55]

Done.

 
   bool operator==(const FilePath& that) const;
 
   bool operator!=(const FilePath& that) const;
 
   // Required for some STL containers and operations
   bool operator<(const FilePath& that) const {
     return path_ < that.path_;
   }
 
@@ skipping 276 matching lines @@
 template<>
 struct hash<base::FilePath> {
   size_t operator()(const base::FilePath& f) const {
     return hash<base::FilePath::StringType>()(f.value());
   }
 };
 
 }  // namespace BASE_HASH_NAMESPACE
 
 #endif  // BASE_FILES_FILE_PATH_H_