chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java - Issue 2627603002: [NTP::SectionOrder] Propagate category rank from UI through the bridge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 2627603002: [NTP::SectionOrder] Propagate category rank from UI through the bridge. (Closed)

Patch Set: 1-based categoryRank -> 0-based categoryIndex. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

index 4525f1f16c2e94dfe3fea99fd0b3a160d8efecb0..a9928ce1f0d291e994b5ab09cb51990abfc6bdc7 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

@@ -147,10 +147,11 @@ public class SnippetsBridge implements SuggestionsSource {

suggestion.mPublishTimestampMilliseconds, suggestion.mScore);

}

- public void onSuggestionOpened(SnippetArticle suggestion, int windowOpenDisposition) {

+ public void onSuggestionOpened(

+ SnippetArticle suggestion, int categoryIndex, int windowOpenDisposition) {

assert mNativeSnippetsBridge != 0;

nativeOnSuggestionOpened(mNativeSnippetsBridge, suggestion.mGlobalPosition,

- suggestion.mCategory, suggestion.mPosition,

+ suggestion.mCategory, categoryIndex, suggestion.mPosition,

suggestion.mPublishTimestampMilliseconds, suggestion.mScore, windowOpenDisposition);

}

@@ -313,8 +314,8 @@ public class SnippetsBridge implements SuggestionsSource {

private native void nativeOnSuggestionShown(long nativeNTPSnippetsBridge, int globalPosition,

int category, int categoryPosition, long publishTimestampMs, float score);

private native void nativeOnSuggestionOpened(long nativeNTPSnippetsBridge, int globalPosition,

- int category, int categoryPosition, long publishTimestampMs, float score,

- int windowOpenDisposition);

+ int category, int categoryIndex, int categoryPosition, long publishTimestampMs,

+ float score, int windowOpenDisposition);

private native void nativeOnSuggestionMenuOpened(long nativeNTPSnippetsBridge,

int globalPosition, int category, int categoryPosition, long publishTimestampMs,

float score);