Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

Issue 2627603002: [NTP::SectionOrder] Propagate category rank from UI through the bridge. (Closed)
Patch Set: 1-based categoryRank -> 0-based categoryIndex. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
index 913e9c296123fbe5adb79fa84e4437b147e65a65..7bb36163aee77476e4905ecc014674e81d4ddbf4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
@@ -70,6 +70,7 @@ public class SnippetArticleViewHolder
private FetchImageCallback mImageCallback;
private SnippetArticle mArticle;
private SuggestionsCategoryInfo mCategoryInfo;
+ private int mCategoryIndex;
private int mPublisherFaviconSizePx;
private final boolean mUseFaviconService;
@@ -117,12 +118,12 @@ public class SnippetArticleViewHolder
@Override
public void onCardTapped() {
- mNewTabPageManager.openSnippet(WindowOpenDisposition.CURRENT_TAB, mArticle);
+ mNewTabPageManager.openSnippet(WindowOpenDisposition.CURRENT_TAB, mArticle, mCategoryIndex);
}
@Override
public void openItem(int windowDisposition) {
- mNewTabPageManager.openSnippet(windowDisposition, mArticle);
+ mNewTabPageManager.openSnippet(windowDisposition, mArticle, mCategoryIndex);
}
@Override
@@ -223,8 +224,8 @@ public class SnippetArticleViewHolder
BidiFormatter.getInstance().unicodeWrap(article.mPublisher), relativeTimeSpan);
}
- public void onBindViewHolder(
- SnippetArticle article, SuggestionsCategoryInfo categoryInfo, List<Object> payloads) {
+ public void onBindViewHolder(SnippetArticle article, SuggestionsCategoryInfo categoryInfo,
+ List<Object> payloads, int categoryIndex) {
if (!payloads.isEmpty() && article.equals(mArticle)) {
performPartialBind(payloads);
return;
@@ -234,6 +235,7 @@ public class SnippetArticleViewHolder
mArticle = article;
mCategoryInfo = categoryInfo;
+ mCategoryIndex = categoryIndex;
updateLayout();
mHeadlineTextView.setText(mArticle.mTitle);

Powered by Google App Engine
This is Rietveld 408576698