chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java - Issue 2627603002: [NTP::SectionOrder] Propagate category rank from UI through the bridge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java

Issue 2627603002: [NTP::SectionOrder] Propagate category rank from UI through the bridge. (Closed)

Patch Set: 1-based categoryRank -> 0-based categoryIndex. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java

index 3f3569758af9fcc9f2699b6d745bdfa8ad493561..8ca0ed49cf9509449895664db7957dc4dec69b4a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java

@@ -109,7 +109,8 @@ public class ContentSuggestionsActivity extends SynchronousInitializationActivit

public void trackSnippetCategoryActionClick(int category, int position) {}

@Override

- public void openSnippet(int windowOpenDisposition, SnippetArticle article) {}

+ public void openSnippet(

+ int windowOpenDisposition, SnippetArticle article, int categoryIndex) {}

@Override

public void focusSearchBox(boolean beginVoiceSearch, String pastedText) {}