Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3856)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

Issue 2627603002: [NTP::SectionOrder] Propagate category rank from UI through the bridge. (Closed)
Patch Set: 1-based categoryRank -> 0-based categoryIndex. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
index 088ee0ac5b9c8190e1ce233fe6a6d697bf86370b..acb529e9137622de7e6178b77b6706d6b21d25dc 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
@@ -80,6 +80,7 @@ public class SuggestionsSection extends InnerNode {
private final List<SnippetArticle> mSuggestions = new ArrayList<>();
private final NewTabPageManager mNewTabPageManager;
private final SuggestionsCategoryInfo mCategoryInfo;
+ private int mCategoryIndex;
public SuggestionsList(NewTabPageManager newTabPageManager,
SuggestionsCategoryInfo categoryInfo) {
@@ -87,6 +88,14 @@ public class SuggestionsSection extends InnerNode {
mCategoryInfo = categoryInfo;
}
+ public void setCategoryIndex(int categoryIndex) {
+ mCategoryIndex = categoryIndex;
+ }
+
+ public int getCategoryIndex() {
+ return mCategoryIndex;
+ }
+
@Override
public int getItemCount() {
return mSuggestions.size();
@@ -105,7 +114,8 @@ public class SuggestionsSection extends InnerNode {
checkIndex(position);
assert holder instanceof SnippetArticleViewHolder;
((SnippetArticleViewHolder) holder)
- .onBindViewHolder(getSuggestionAt(position), mCategoryInfo, payloads);
+ .onBindViewHolder(
+ getSuggestionAt(position), mCategoryInfo, payloads, mCategoryIndex);
}
@Override
@@ -426,6 +436,14 @@ public class SuggestionsSection extends InnerNode {
return mCategoryInfo;
}
+ public int getCategoryIndex() {
+ return mSuggestionsList.getCategoryIndex();
+ }
+
+ public void setCategoryIndex(int categoryIndex) {
+ mSuggestionsList.setCategoryIndex(categoryIndex);
+ }
+
public String getHeaderText() {
return mHeader.getHeaderText();
}

Powered by Google App Engine
This is Rietveld 408576698