Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2627563002: Generated unicode-bidi in ComputedStyleBase (Closed)

Created:
3 years, 11 months ago by sashab
Modified:
3 years, 11 months ago
Reviewers:
napper, amoylan
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Generated unicode-bidi in ComputedStyleBase Moved unicode-bidi to be generated in ComputedStyleBase, which uses the external type platform/text/UnicodeBidi. Review-Url: https://codereview.chromium.org/2627563002 Cr-Commit-Position: refs/heads/master@{#443099} Committed: https://chromium.googlesource.com/chromium/src/+/b0066bb30891e0b360155b3fabfb9d01a10ad8bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 4 chunks +1 line, -14 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 2 chunks +1 line, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (10 generated)
sashab
3 years, 11 months ago (2017-01-10 05:25:41 UTC) #5
napper
lgtm
3 years, 11 months ago (2017-01-10 05:30:07 UTC) #6
sashab
amoylan PTAL :)
3 years, 11 months ago (2017-01-10 23:16:21 UTC) #10
tomjamri
On 2017/01/10 05:30:07, napper wrote: > lgtm
3 years, 11 months ago (2017-01-10 23:29:35 UTC) #11
tomjamri
On 2017/01/10 05:30:07, napper wrote: > lgtm
3 years, 11 months ago (2017-01-10 23:35:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627563002/1
3 years, 11 months ago (2017-01-11 23:26:22 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 01:07:49 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b0066bb30891e0b360155b3fabfb...

Powered by Google App Engine
This is Rietveld 408576698