Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2627543002: ServiceWorker: Returns true for IsMojoForServiceWorkerEnabled (Closed)

Created:
3 years, 11 months ago by shimazu
Modified:
3 years, 11 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Returns true for IsMojoForServiceWorkerEnabled This patch: - changes ServiceWorkerUtils::IsMojoForServiceWorkerEnabled to return always true instead of checking the --disable-mojo-service-worker flag (currently it already returns true by default) - removes unit tests with --disable-mojo-service-worker Layout tests will also be removed at a subsequent patch. BUG=629701 Review-Url: https://codereview.chromium.org/2627543002 Cr-Commit-Position: refs/heads/master@{#442516} Committed: https://chromium.googlesource.com/chromium/src/+/41ba1486431391060dd80bce6b6f60ffe0a8df8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+428 lines, -784 lines) Patch
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 15 chunks +23 lines, -76 lines 0 comments Download
M content/browser/service_worker/embedded_worker_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/link_header_support_unittest.cc View 17 chunks +16 lines, -25 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 49 chunks +54 lines, -89 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_writer_unittest.cc View 19 chunks +18 lines, -25 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core_unittest.cc View 2 chunks +1 line, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_context_request_handler_unittest.cc View 6 chunks +5 lines, -12 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 16 chunks +50 lines, -105 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc View 8 chunks +6 lines, -14 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 28 chunks +26 lines, -36 lines 0 comments Download
M content/browser/service_worker/service_worker_handle_unittest.cc View 2 chunks +5 lines, -19 lines 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 36 chunks +45 lines, -80 lines 0 comments Download
M content/browser/service_worker/service_worker_process_manager.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_process_manager_unittest.cc View 5 chunks +4 lines, -11 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.h View 2 chunks +9 lines, -9 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host_unittest.cc View 5 chunks +4 lines, -11 lines 0 comments Download
M content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc View 4 chunks +3 lines, -10 lines 0 comments Download
M content/browser/service_worker/service_worker_registration_unittest.cc View 9 chunks +9 lines, -20 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler_unittest.cc View 3 chunks +8 lines, -15 lines 0 comments Download
M content/browser/service_worker/service_worker_storage_unittest.cc View 26 chunks +31 lines, -50 lines 0 comments Download
M content/browser/service_worker/service_worker_test_utils.h View 1 chunk +0 lines, -15 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 18 chunks +17 lines, -24 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 2 chunks +16 lines, -17 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 42 chunks +50 lines, -71 lines 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc View 15 chunks +15 lines, -28 lines 0 comments Download
M content/common/service_worker/service_worker_utils.cc View 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
shimazu
ptal!
3 years, 11 months ago (2017-01-10 03:30:18 UTC) #4
falken
lgtm but let's make the CL description more clear what's changed. Imagine someone is investigating ...
3 years, 11 months ago (2017-01-10 03:46:35 UTC) #5
shimazu
On 2017/01/10 03:46:35, falken wrote: > lgtm but let's make the CL description more clear ...
3 years, 11 months ago (2017-01-10 03:59:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627543002/1
3 years, 11 months ago (2017-01-10 03:59:33 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 06:18:32 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/41ba1486431391060dd80bce6b6f...

Powered by Google App Engine
This is Rietveld 408576698