Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2619883004: Remove --disable-mojo-service-worker (Closed)

Created:
3 years, 11 months ago by shimazu
Modified:
3 years, 11 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, blink-reviews, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove --disable-mojo-service-worker https://crrev.com/2627543002 removes the non-mojo path. Let's remove the non-mojo tests and the flag to run non-mojo path. BUG=629701

Patch Set 1 #

Patch Set 2 : Remove --disable-mojo-service-worker #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/LeakExpectations View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/SlowTests View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/disable-mojo-service-worker/http/tests/serviceworker/README.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 24 (16 generated)
shimazu
ptal
3 years, 11 months ago (2017-01-10 03:50:24 UTC) #4
falken
lgtm
3 years, 11 months ago (2017-01-10 03:52:28 UTC) #5
shimazu
avi@chromium.org: Please review changes in render_process_host_impl.cc and content_switches?
3 years, 11 months ago (2017-01-10 06:23:08 UTC) #7
shimazu
avi@: kindly ping?
3 years, 11 months ago (2017-01-12 03:58:37 UTC) #16
Avi (use Gerrit)
Thank you for the ping; I had missed this. LGTM
3 years, 11 months ago (2017-01-12 05:00:44 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619883004/60001
3 years, 11 months ago (2017-01-12 05:12:03 UTC) #20
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 11 months ago (2017-01-12 07:05:40 UTC) #23
shimazu
3 years, 11 months ago (2017-01-12 07:46:40 UTC) #24
On 2017/01/12 07:05:40, commit-bot: I haz the power wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the
> issue was successfully committed. Please check Git history manually and
re-check
> CQ or close this issue as needed.

Landed as https://crrev.com/0d91b4b25cdb0f9164ead9ad40654e08289bcc3b.

Powered by Google App Engine
This is Rietveld 408576698