Source/core/html/HTMLMediaElement.idl - Issue 262753004: Replace all remaining IDL finitude type checks with [TypeChecking=Unrestricted]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.idl

Issue 262753004: Replace all remaining IDL finitude type checks with [TypeChecking=Unrestricted] (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove unnecessary code (std::isfinite not needed for long) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLMediaElement.idl

diff --git a/Source/core/html/HTMLMediaElement.idl b/Source/core/html/HTMLMediaElement.idl

index ccc69399b457a783d13a44ded382ca191ef50386..d505be7c7c951fe736fe513fc0a18069040615a7 100644

--- a/Source/core/html/HTMLMediaElement.idl

+++ b/Source/core/html/HTMLMediaElement.idl

@@ -26,6 +26,7 @@

[

ActiveDOMObject,

RuntimeEnabled=Media,

+ TypeChecking=Unrestricted,

] interface HTMLMediaElement : HTMLElement {

// error state

@@ -57,12 +58,11 @@

readonly attribute boolean seeking;

// playback state

- // FIXME: generated bindings should check isfinite: http://crbug.com/354298

[RaisesException=Setter] attribute double currentTime;

readonly attribute unrestricted double duration;

readonly attribute boolean paused;

- [RaisesException=Setter] attribute double defaultPlaybackRate;

- [RaisesException=Setter] attribute double playbackRate;

+ attribute double defaultPlaybackRate;

+ attribute double playbackRate;

readonly attribute TimeRanges played;

readonly attribute TimeRanges seekable;

readonly attribute boolean ended;

« no previous file with comments | « Source/core/html/HTMLMediaElement.cpp ('k') | Source/core/html/HTMLMeterElement.h » ('j') | Source/core/html/track/vtt/VTTCue.cpp » ('J')