| Index: Source/core/html/HTMLMediaElement.cpp
|
| diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp
|
| index 917eaef80118a6b162d987269435bb06d7a6b84d..d5095be123ec94c9de987eebce36db2928a6ed73 100644
|
| --- a/Source/core/html/HTMLMediaElement.cpp
|
| +++ b/Source/core/html/HTMLMediaElement.cpp
|
| @@ -684,7 +684,7 @@ void HTMLMediaElement::prepareForLoad()
|
| }
|
|
|
| // 5 - Set the playbackRate attribute to the value of the defaultPlaybackRate attribute.
|
| - setPlaybackRate(defaultPlaybackRate(), IGNORE_EXCEPTION);
|
| + setPlaybackRate(defaultPlaybackRate());
|
|
|
| // 6 - Set the error attribute to null and the autoplaying flag to true.
|
| m_error = nullptr;
|
| @@ -1886,11 +1886,6 @@ double HTMLMediaElement::currentTime() const
|
|
|
| void HTMLMediaElement::setCurrentTime(double time, ExceptionState& exceptionState)
|
| {
|
| - // FIXME: generated bindings should check isfinite: http://crbug.com/354298
|
| - if (!std::isfinite(time)) {
|
| - exceptionState.throwTypeError(ExceptionMessages::notAFiniteNumber(time));
|
| - return;
|
| - }
|
| if (m_mediaController) {
|
| exceptionState.throwDOMException(InvalidStateError, "The element is slaved to a MediaController.");
|
| return;
|
| @@ -1929,17 +1924,13 @@ double HTMLMediaElement::defaultPlaybackRate() const
|
| return m_defaultPlaybackRate;
|
| }
|
|
|
| -void HTMLMediaElement::setDefaultPlaybackRate(double rate, ExceptionState& exceptionState)
|
| +void HTMLMediaElement::setDefaultPlaybackRate(double rate)
|
| {
|
| - // FIXME: generated bindings should check isfinite: http://crbug.com/354298
|
| - if (!std::isfinite(rate)) {
|
| - exceptionState.throwTypeError(ExceptionMessages::notAFiniteNumber(rate));
|
| + if (m_defaultPlaybackRate == rate)
|
| return;
|
| - }
|
| - if (m_defaultPlaybackRate != rate) {
|
| - m_defaultPlaybackRate = rate;
|
| - scheduleEvent(EventTypeNames::ratechange);
|
| - }
|
| +
|
| + m_defaultPlaybackRate = rate;
|
| + scheduleEvent(EventTypeNames::ratechange);
|
| }
|
|
|
| double HTMLMediaElement::playbackRate() const
|
| @@ -1947,16 +1938,10 @@ double HTMLMediaElement::playbackRate() const
|
| return m_playbackRate;
|
| }
|
|
|
| -void HTMLMediaElement::setPlaybackRate(double rate, ExceptionState& exceptionState)
|
| +void HTMLMediaElement::setPlaybackRate(double rate)
|
| {
|
| WTF_LOG(Media, "HTMLMediaElement::setPlaybackRate(%f)", rate);
|
|
|
| - // FIXME: generated bindings should check isfinite: http://crbug.com/354298
|
| - if (!std::isfinite(rate)) {
|
| - exceptionState.throwTypeError(ExceptionMessages::notAFiniteNumber(rate));
|
| - return;
|
| - }
|
| -
|
| if (m_playbackRate != rate) {
|
| m_playbackRate = rate;
|
| invalidateCachedTime();
|
| @@ -2121,22 +2106,17 @@ void HTMLMediaElement::setVolume(double vol, ExceptionState& exceptionState)
|
| {
|
| WTF_LOG(Media, "HTMLMediaElement::setVolume(%f)", vol);
|
|
|
| - // FIXME: generated bindings should check isfinite: http://crbug.com/354298
|
| - if (!std::isfinite(vol)) {
|
| - exceptionState.throwTypeError(ExceptionMessages::notAFiniteNumber(vol));
|
| + if (m_volume == vol)
|
| return;
|
| - }
|
|
|
| if (vol < 0.0f || vol > 1.0f) {
|
| exceptionState.throwDOMException(IndexSizeError, ExceptionMessages::indexOutsideRange("volume", vol, 0.0, ExceptionMessages::InclusiveBound, 1.0, ExceptionMessages::InclusiveBound));
|
| return;
|
| }
|
|
|
| - if (m_volume != vol) {
|
| - m_volume = vol;
|
| - updateVolume();
|
| - scheduleEvent(EventTypeNames::volumechange);
|
| - }
|
| + m_volume = vol;
|
| + updateVolume();
|
| + scheduleEvent(EventTypeNames::volumechange);
|
| }
|
|
|
| bool HTMLMediaElement::muted() const
|
|
|