Move WPT fetch out of the LocalWPT constructor.

Move WPT fetch out of the LocalWPT constructor.

BUG=679955
Review-Url: https://codereview.chromium.org/2627323008
Cr-Commit-Position: refs/heads/master@{#444522}
Committed: https://chromium.googlesource.com/chromium/src/+/1af3b5587d608b0417f3784703f8d389742cded0

[qyearsley, 2017-01-16 00:48:51]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[qyearsley, 2017-01-16 00:48:56]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[commit-bot: I haz the power, 2017-01-16 00:49:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 02:08:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 02:08:23]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2017-01-18 00:23:45]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 00:24:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 01:33:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 01:33:25]

Dry run: This issue passed the CQ dry run.

[jeffcarp, 2017-01-18 20:21:23]

https://codereview.chromium.org/2627323008/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py
(right):

https://codereview.chromium.org/2627323008/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py:29: ])
Is this the proper way to format? I'm always confused.

https://codereview.chromium.org/2627323008/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py:42: #
Looks like this got left behind

[jeffcarp, 2017-01-18 20:21:27]

lgtm

[qyearsley, 2017-01-18 22:35:39]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-01-18 22:36:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 22:44:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484778939494480,
"parent_rev": "8d3b263c6e8053d2447b4ce008ec0e793c40e5f5", "commit_rev":
"1af3b5587d608b0417f3784703f8d389742cded0"}

[commit-bot: I haz the power, 2017-01-18 22:44:48]

Description was changed from

==========
Move WPT fetch out of the LocalWPT constructor.

BUG=679955
==========

to

==========
Move WPT fetch out of the LocalWPT constructor.

BUG=679955

Review-Url: https://codereview.chromium.org/2627323008
Cr-Commit-Position: refs/heads/master@{#444522}
Committed:
https://chromium.googlesource.com/chromium/src/+/1af3b5587d608b0417f3784703f8...
==========

[commit-bot: I haz the power, 2017-01-18 22:44:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1af3b5587d608b0417f3784703f8...

[qyearsley, 2017-01-18 23:26:25]

https://codereview.chromium.org/2627323008/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py
(right):

https://codereview.chromium.org/2627323008/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py:29: ])
On 2017/01/18 at 20:21:22, jeffcarp wrote:
> Is this the proper way to format? I'm always confused.

There are multiple proper ways. The main rules are:
 - For multiline dicts/lists, the close bracket is lined up with the start of
the line that has the start bracket.
 - For function arguments, you can either break right after the open parenthesis
or not. Either way, all function arguments after line breaks should be lined up
with the first argument.

See https://www.python.org/dev/peps/pep-0008/#code-lay-out

As long as the linter doesn't complain, it's OK. So, some valid styles include:

my_function([...])
my_function([
   ...,
   ...,
])
my_function(
    [...])
my_function(
    [...,
     ...])

But it's always good to be consistent with surrounding code, and in order to
make it easy to insert/add lines, I would tend to prefer:

my_function([
    ...,
    ...,
])
OR
my_function(
    [
        ...,
        ...,
    ])

https://codereview.chromium.org/2627323008/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py:42: #
On 2017/01/18 at 20:21:23, jeffcarp wrote:
> Looks like this got left behind

Oh! I didn't see this comment. Will have to clean up later.