Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py

Issue 2627323008: Move WPT fetch out of the LocalWPT constructor. (Closed)
Patch Set: Move WPT fetch out of the LocalWPT constructor. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
index ef0501d613469631e758179fab2c60a7195079c8..2c43c08a420a8dd40f583f83502e82306ef6e19c 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
@@ -10,7 +10,7 @@ from webkitpy.common.system.executive import ScriptError
from webkitpy.w3c.chromium_commit import ChromiumCommit
WPT_REPO_URL = 'https://chromium.googlesource.com/external/w3c/web-platform-tests.git'
-WPT_TMP_DIR = '/tmp/wpt'
+WPT_TEMP_DIR = '/tmp/wpt'
WPT_SSH_URL = 'git@github.com:w3c/web-platform-tests.git'
REMOTE_NAME = 'github'
CHROMIUM_WPT_DIR = 'third_party/WebKit/LayoutTests/external/wpt/'
@@ -20,22 +20,19 @@ _log = logging.getLogger(__name__)
class LocalWPT(object):
- def __init__(self, host, path=WPT_TMP_DIR, no_fetch=False):
+ def __init__(self, host, path=WPT_TEMP_DIR):
"""
Args:
host: A Host object.
- path: Optional, the directory where LocalWPT will check out web-platform-tests.
- no_fetch: Optional, passing true will skip updating the local WPT.
- Intended for use only in development after fetching once.
+ path: Optional, the path to the web-platform-tests repo.
+ If this directory already exists, it is assumed that the
+ web-platform-tests repo is already checked out at this path.
"""
self.host = host
self.path = path
self.branch_name = 'chromium-export-try'
- if no_fetch:
- _log.info('Skipping remote WPT fetch')
- return
-
+ def fetch(self):
if self.host.filesystem.exists(self.path):
_log.info('WPT checkout exists at %s, fetching latest', self.path)
self.run(['git', 'fetch', '--all'])
@@ -122,7 +119,7 @@ class LocalWPT(object):
self.run(['git', 'apply', '-'], input=patch)
self.run(['git', 'add', '.'])
output = self.run(['git', 'diff', 'origin/master'])
- except ScriptError as error:
+ except ScriptError:
_log.warning('Patch did not apply cleanly, skipping...')
output = ''

Powered by Google App Engine
This is Rietveld 408576698