Issue 26273006: Check lockPixel failure in SkBitmapProcState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26273006: Check lockPixel failure in SkBitmapProcState (Closed)

Created:
7 years, 2 months ago by Xianzhu

Modified:
7 years, 2 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Check lockPixel failure in SkBitmapProcState crbug.com/295895 is about a crash in Skia when a lazy-decoded image fails to lockPixels() because of broken data. Check lockPixel failure to avoid the crash. BUG=chromium:295895 TEST=open chrome/src/third_party/WebKit/LayoutTests/canvas/philip/images/broken.png in a browser with lazy-decoding enabled (e.g. Chrome Android).

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	src/core/SkBitmapProcState.cpp	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

reed1

7 years, 2 months ago (2013-10-15 18:23:44 UTC) #1

I have written a test case (local to skia) that *seems* to fail in the same
manner. This CL fixes that. Can you try out this CL to see if it fixes your
failure as well?

https://codereview.chromium.org/27382002

Expand Messages | Collapse Messages