Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 27382002: return false if we can't scale, to force us to try to lock the original and then proceed (Closed)

Created:
7 years, 2 months ago by reed1
Modified:
7 years, 2 months ago
Reviewers:
Xianzhu
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

return false if we can't scale, to force us to try to lock the original and then proceed BUG= R=wangxianzhu@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=11789

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M src/core/SkBitmapProcState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/DrawBitmapRectTest.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
reed1
7 years, 2 months ago (2013-10-15 18:24:46 UTC) #1
Xianzhu
lgtm. Does this resolve the crash caused by failure of later lockPixels()?
7 years, 2 months ago (2013-10-15 18:45:12 UTC) #2
Xianzhu
On 2013/10/15 18:45:12, Xianzhu wrote: > lgtm. > > Does this resolve the crash caused ...
7 years, 2 months ago (2013-10-15 18:46:10 UTC) #3
reed1
On 2013/10/15 18:45:12, Xianzhu wrote: > lgtm. > > Does this resolve the crash caused ...
7 years, 2 months ago (2013-10-15 19:43:24 UTC) #4
reed1
7 years, 2 months ago (2013-10-15 20:14:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r11789 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698