Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2627113002: [Android] Refactor AwSettingsTest to replace deprecated package org.apache.http (Closed)

Created:
3 years, 11 months ago by shenghuazhang
Modified:
3 years, 11 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Refactor AwSettingsTest to replace deprecated package org.apache.http BUG=488194 Review-Url: https://codereview.chromium.org/2627113002 Cr-Commit-Position: refs/heads/master@{#443120} Committed: https://chromium.googlesource.com/chromium/src/+/1916748e2f13a9f80080d010a9adc6ba74028a59

Patch Set 1 #

Total comments: 1

Patch Set 2 : sgnrun comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -19 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 1 3 chunks +14 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
shenghuazhang
3 years, 11 months ago (2017-01-11 19:24:45 UTC) #2
jbudorick
lgtm
3 years, 11 months ago (2017-01-11 20:01:02 UTC) #3
sgurun-gerrit only
lgtm with nits https://codereview.chromium.org/2627113002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java (right): https://codereview.chromium.org/2627113002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java#newcode1762 android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:1762: String url = testServer.getURL("/echoheader?User-Agent"); nit add ...
3 years, 11 months ago (2017-01-11 23:20:44 UTC) #4
shenghuazhang
3 years, 11 months ago (2017-01-11 23:42:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627113002/20001
3 years, 11 months ago (2017-01-12 01:08:52 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 02:31:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1916748e2f13a9f80080d010a9ad...

Powered by Google App Engine
This is Rietveld 408576698