Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1626)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

Issue 2627113002: [Android] Refactor AwSettingsTest to replace deprecated package org.apache.http (Closed)
Patch Set: sgnrun comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
index c060004c456a62bf9150d464c0cee2be13400d9f..d1f8f367ac09d1f8fe318047e2cabf3407a9de3c 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
@@ -20,9 +20,6 @@ import android.webkit.ValueCallback;
import android.webkit.WebSettings;
import android.webkit.WebSettings.LayoutAlgorithm;
-import org.apache.http.Header;
-import org.apache.http.HttpRequest;
-
import org.chromium.android_webview.AwContents;
import org.chromium.android_webview.AwSettings;
import org.chromium.android_webview.AwWebResourceResponse;
@@ -41,6 +38,7 @@ import org.chromium.content.browser.test.util.DOMUtils;
import org.chromium.content.browser.test.util.HistoryUtils;
import org.chromium.content.browser.test.util.TestCallbackHelperContainer;
import org.chromium.content_public.browser.WebContents;
+import org.chromium.net.test.EmbeddedTestServer;
import org.chromium.net.test.util.TestWebServer;
import org.chromium.ui.display.DisplayAndroid;
@@ -1751,31 +1749,28 @@ public class AwSettingsTest extends AwTestBase {
final TestAwContentsClient contentClient = new TestAwContentsClient();
final AwTestContainerView testContainerView =
createAwTestContainerViewOnMainSync(contentClient);
- AwContents awContents = testContainerView.getAwContents();
- AwSettings settings = getAwSettingsOnUiThread(awContents);
final String customUserAgentString =
"testUserAgentWithTestServerUserAgent";
+ AwContents awContents = testContainerView.getAwContents();
+ AwSettings settings = getAwSettingsOnUiThread(awContents);
+ EmbeddedTestServer testServer =
+ EmbeddedTestServer.createAndStartServer(getInstrumentation().getContext());
- String fileName = null;
- TestWebServer webServer = TestWebServer.start();
- try {
- final String httpPath = "/testUserAgentWithTestServer.html";
- final String url = webServer.setResponse(httpPath, "foo", null);
+ enableJavaScriptOnUiThread(awContents);
+ try {
+ // Create url with echoheader echoing the User-Agent header in the the html body.
+ String url = testServer.getURL("/echoheader?User-Agent");
settings.setUserAgentString(customUserAgentString);
loadUrlSync(awContents,
contentClient.getOnPageFinishedHelper(),
url);
-
- assertEquals(1, webServer.getRequestCount(httpPath));
- HttpRequest request = webServer.getLastRequest(httpPath);
- Header[] matchingHeaders = request.getHeaders("User-Agent");
- assertEquals(1, matchingHeaders.length);
-
- Header header = matchingHeaders[0];
- assertEquals(customUserAgentString, header.getValue());
+ String userAgent = maybeStripDoubleQuotes(JSUtils.executeJavaScriptAndWaitForResult(
+ this, awContents, contentClient.getOnEvaluateJavaScriptResultHelper(),
+ "document.body.textContent"));
+ assertEquals(customUserAgentString, userAgent);
} finally {
- webServer.shutdown();
+ testServer.stopAndDestroyServer();
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698