Create proper object types when loading host cache.

Create proper object types when loading host cache.

I suspect that host.options was originally a simple dictionary, and so the cast was safe. When it got upgraded to an object with methods on the prototype it broke, but because the window of opportunity for failure is small (you have to connect without a call to HostList.refresh happening in the interim), it was difficult to track down.

BUG=680302
Review-Url: https://codereview.chromium.org/2621403004
Cr-Commit-Position: refs/heads/master@{#443072}
(cherry picked from commit 90d7824a5136d081090646b7ec7f7158aaae8aca)

Review-Url: https://codereview.chromium.org/2627073005 .
Cr-Commit-Position: refs/branch-heads/2924@{#754}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Committed: https://chromium.googlesource.com/chromium/src/+/881bcc9c0073e39ccd53444b19fb72a4def29a52

[Jamie, 2017-01-13 02:05:20]

Description was changed from

==========
Create proper object types when loading host cache.

I suspect that host.options was originally a simple dictionary, and so the cast
was safe. When it got upgraded to an object with methods on the prototype it
broke, but because the window of opportunity for failure is small (you have to
connect without a call to HostList.refresh happening in the interim), it was
difficult to track down.

BUG=680302

Review-Url: https://codereview.chromium.org/2621403004
Cr-Commit-Position: refs/heads/master@{#443072}
(cherry picked from commit 90d7824a5136d081090646b7ec7f7158aaae8aca)
==========

to

==========
Create proper object types when loading host cache.

I suspect that host.options was originally a simple dictionary, and so the cast
was safe. When it got upgraded to an object with methods on the prototype it
broke, but because the window of opportunity for failure is small (you have to
connect without a call to HostList.refresh happening in the interim), it was
difficult to track down.

BUG=680302

Review-Url: https://codereview.chromium.org/2621403004
Cr-Commit-Position: refs/heads/master@{#443072}
(cherry picked from commit 90d7824a5136d081090646b7ec7f7158aaae8aca)

Review-Url: https://codereview.chromium.org/2627073005 .
Cr-Commit-Position: refs/branch-heads/2924@{#754}
Cr-Branched-From:
3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Committed:
https://chromium.googlesource.com/chromium/src/+/881bcc9c0073e39ccd53444b19fb...
==========

[Jamie, 2017-01-13 02:05:21]

Committed patchset #1 (id:1) manually as
881bcc9c0073e39ccd53444b19fb72a4def29a52.