Create proper object types when loading host cache.

Create proper object types when loading host cache.

I suspect that host.options was originally a simple dictionary, and so the cast was safe. When it got upgraded to an object with methods on the prototype it broke, but because the window of opportunity for failure is small (you have to connect without a call to HostList.refresh happening in the interim), it was difficult to track down.

BUG=680302
Review-Url: https://codereview.chromium.org/2621403004
Cr-Commit-Position: refs/heads/master@{#443072}
Committed: https://chromium.googlesource.com/chromium/src/+/90d7824a5136d081090646b7ec7f7158aaae8aca

[Jamie, 2017-01-11 21:08:44]

Description was changed from

==========
Create proper object types when loading host cache.
==========

to

==========
Create proper object types when loading host cache.

I suspect that host.options was originally a simple dictionary, and so the cast
was safe. When it got upgraded to an object with methods on the prototype it
broke, but because the window of opportunity for failure is small (you have to
connect without a call to HostList.refresh happening in the interim), it was
difficult to track down.
==========

[Jamie, 2017-01-11 21:08:44]

jamiewalch@chromium.org changed reviewers:
+ kelvinp@chromium.org

[kelvinp, 2017-01-11 23:06:57]

lgtm

[Jamie, 2017-01-11 23:16:24]

The CQ bit was checked by jamiewalch@chromium.org

[commit-bot: I haz the power, 2017-01-11 23:17:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jamie, 2017-01-11 23:19:38]

Description was changed from

==========
Create proper object types when loading host cache.

I suspect that host.options was originally a simple dictionary, and so the cast
was safe. When it got upgraded to an object with methods on the prototype it
broke, but because the window of opportunity for failure is small (you have to
connect without a call to HostList.refresh happening in the interim), it was
difficult to track down.
==========

to

==========
Create proper object types when loading host cache.

I suspect that host.options was originally a simple dictionary, and so the cast
was safe. When it got upgraded to an object with methods on the prototype it
broke, but because the window of opportunity for failure is small (you have to
connect without a call to HostList.refresh happening in the interim), it was
difficult to track down.

BUG=680302
==========

[commit-bot: I haz the power, 2017-01-12 00:15:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484176584873360, "parent_rev":
"96557bfa11c102628943935e7906cff4b3b04a74", "commit_rev":
"90d7824a5136d081090646b7ec7f7158aaae8aca"}

[commit-bot: I haz the power, 2017-01-12 00:17:01]

Description was changed from

==========
Create proper object types when loading host cache.

I suspect that host.options was originally a simple dictionary, and so the cast
was safe. When it got upgraded to an object with methods on the prototype it
broke, but because the window of opportunity for failure is small (you have to
connect without a call to HostList.refresh happening in the interim), it was
difficult to track down.

BUG=680302
==========

to

==========
Create proper object types when loading host cache.

I suspect that host.options was originally a simple dictionary, and so the cast
was safe. When it got upgraded to an object with methods on the prototype it
broke, but because the window of opportunity for failure is small (you have to
connect without a call to HostList.refresh happening in the interim), it was
difficult to track down.

BUG=680302

Review-Url: https://codereview.chromium.org/2621403004
Cr-Commit-Position: refs/heads/master@{#443072}
Committed:
https://chromium.googlesource.com/chromium/src/+/90d7824a5136d081090646b7ec7f...
==========

[commit-bot: I haz the power, 2017-01-12 00:17:02]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/90d7824a5136d081090646b7ec7f...