Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2627033003: Update some comments about variations headers API use. (Closed)

Created:
3 years, 11 months ago by Alexei Svitkine (slow)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jdonnelly+watch_chromium.org, pkl (ping after 24h if needed), ntp-dev+reviews_chromium.org, rouslan+autofill_chromium.org, grt+watch_chromium.org, sebsg+autofillwatch_chromium.org, donnd+watch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, marq+watch_chromium.org, twellington+watch_chromium.org, noyau+watch_chromium.org, joenotcharles+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, ftirelo+watch_chromium.org, alito+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update some comments about variations headers API use. Based on post-review comments on: https://codereview.chromium.org/2558913003/ BUG=none TBR=mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org,noyau@chromium.org Review-Url: https://codereview.chromium.org/2627033003 Cr-Commit-Position: refs/heads/master@{#443250} Committed: https://chromium.googlesource.com/chromium/src/+/b2ea4c9c7a315e6da453842076f6ebee657bd371

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove extra . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M chrome/browser/android/contextualsearch/contextual_search_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/srt_fetcher_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_download_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/feedback/feedback_uploader_chrome.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/ntp_snippets/remote/ntp_snippets_json_request.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/omnibox/browser/search_provider.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/omnibox/browser/zero_suggest_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/suggestions/suggestions_service_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Alexei Svitkine (slow)
3 years, 11 months ago (2017-01-11 22:33:24 UTC) #2
Mathieu
autofill lgtm https://codereview.chromium.org/2627033003/diff/1/components/autofill/core/browser/autofill_download_manager.cc File components/autofill/core/browser/autofill_download_manager.cc (right): https://codereview.chromium.org/2627033003/diff/1/components/autofill/core/browser/autofill_download_manager.cc#newcode251 components/autofill/core/browser/autofill_download_manager.cc:251: // not affect transmission of experiments coming ...
3 years, 11 months ago (2017-01-11 22:33:57 UTC) #4
Mark P
components/omnibox/... lgtm
3 years, 11 months ago (2017-01-11 22:34:58 UTC) #5
Alexei Svitkine (slow)
https://codereview.chromium.org/2627033003/diff/1/components/autofill/core/browser/autofill_download_manager.cc File components/autofill/core/browser/autofill_download_manager.cc (right): https://codereview.chromium.org/2627033003/diff/1/components/autofill/core/browser/autofill_download_manager.cc#newcode251 components/autofill/core/browser/autofill_download_manager.cc:251: // not affect transmission of experiments coming from the ...
3 years, 11 months ago (2017-01-11 22:36:50 UTC) #6
Alexei Svitkine (slow)
TBR += mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org,noyau@chromium.org Since this is a downstream change of the variations request headers API.
3 years, 11 months ago (2017-01-12 15:20:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627033003/20001
3 years, 11 months ago (2017-01-12 15:21:31 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/b2ea4c9c7a315e6da453842076f6ebee657bd371
3 years, 11 months ago (2017-01-12 16:13:59 UTC) #17
mattm
3 years, 11 months ago (2017-01-12 22:05:20 UTC) #18
Message was sent while issue was closed.
safe_browsing lgtm

Powered by Google App Engine
This is Rietveld 408576698