Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: components/ntp_snippets/remote/ntp_snippets_json_request.cc

Issue 2627033003: Update some comments about variations headers API use. (Closed)
Patch Set: Remove extra . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/feedback/feedback_uploader_chrome.cc ('k') | components/omnibox/browser/search_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/remote/ntp_snippets_json_request.cc
diff --git a/components/ntp_snippets/remote/ntp_snippets_json_request.cc b/components/ntp_snippets/remote/ntp_snippets_json_request.cc
index 4d50f652efadf52d21daadaa22541a4d47ae1be2..7ac4f5cd3436ad42394faf919ae1620355d49744 100644
--- a/components/ntp_snippets/remote/ntp_snippets_json_request.cc
+++ b/components/ntp_snippets/remote/ntp_snippets_json_request.cc
@@ -356,8 +356,8 @@ std::string NTPSnippetsJsonRequest::Builder::BuildHeaders() const {
headers.SetHeader("Authorization", auth_header_);
}
// Add X-Client-Data header with experiment IDs from field trials.
- // Note: It's fine to pass in |is_signed_in| false, which does not affect
- // transmission of experiment ids coming from the variations server.
+ // Note: It's OK to pass |is_signed_in| false if it's unknown, as it does
+ // not affect transmission of experiments coming from the variations server.
bool is_signed_in = false;
variations::AppendVariationHeaders(url_,
false, // incognito
« no previous file with comments | « components/feedback/feedback_uploader_chrome.cc ('k') | components/omnibox/browser/search_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698