Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2627003005: [printing] Remove duplicate code that prints property details. (Closed)

Created:
3 years, 11 months ago by Igor Sheludko
Modified:
3 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[printing] Remove duplicate code that prints property details. BUG= Review-Url: https://codereview.chromium.org/2627003005 Cr-Commit-Position: refs/heads/master@{#42291} Committed: https://chromium.googlesource.com/v8/v8/+/5d85e8ccf90d92f447c0ea9899e6499303355c31

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -92 lines) Patch
M src/map-updater.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 3 chunks +6 lines, -2 lines 0 comments Download
M src/objects.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M src/objects-inl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/objects-printer.cc View 5 chunks +43 lines, -30 lines 0 comments Download
M src/property.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/property.cc View 1 chunk +24 lines, -41 lines 2 comments Download
M src/property-details.h View 2 chunks +13 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
Igor Sheludko
PTAL
3 years, 11 months ago (2017-01-12 15:03:45 UTC) #4
Jakob Kummerow
LGTM https://codereview.chromium.org/2627003005/diff/1/src/property.cc File src/property.cc (right): https://codereview.chromium.org/2627003005/diff/1/src/property.cc#newcode50 src/property.cc:50: os << ":" << representation().Mnemonic(); nit: might want ...
3 years, 11 months ago (2017-01-12 15:53:20 UTC) #7
Igor Sheludko
https://codereview.chromium.org/2627003005/diff/1/src/property.cc File src/property.cc (right): https://codereview.chromium.org/2627003005/diff/1/src/property.cc#newcode50 src/property.cc:50: os << ":" << representation().Mnemonic(); On 2017/01/12 15:53:20, Jakob ...
3 years, 11 months ago (2017-01-12 15:56:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627003005/1
3 years, 11 months ago (2017-01-12 21:20:51 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 21:22:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5d85e8ccf90d92f447c0ea9899e64993033...

Powered by Google App Engine
This is Rietveld 408576698