[runtime] Use PropertyKind/PropertyLocation instead of PropertyType.

[runtime] Use PropertyKind/PropertyLocation instead of PropertyType.

This is a necessary cleanup before introducing PropertyConstness bit.

BUG=v8:5495
Review-Url: https://codereview.chromium.org/2624903003
Cr-Commit-Position: refs/heads/master@{#42277}
Committed: https://chromium.googlesource.com/v8/v8/+/d3d57ebaf6cd7084892aae37c3e54293c07b65b8

[Igor Sheludko, 2017-01-11 18:00:35]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 18:00:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 18:35:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 18:35:33]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2017-01-12 08:59:47]

ishell@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Igor Sheludko, 2017-01-12 08:59:48]

PTAL

[Igor Sheludko, 2017-01-12 13:02:28]

Patchset #2 (id:20001) has been deleted

[Igor Sheludko, 2017-01-12 15:06:28]

Description was changed from

==========
[runtime] Stop using PropertyType and start using PropertyKind/PropertyLocation
instead.

This is a necessary cleanup before introducing PropertyConstness bit.

BUG=v8:5495
==========

to

==========
[runtime] Use PropertyKind/PropertyLocation instead of PropertyType.

This is a necessary cleanup before introducing PropertyConstness bit.

BUG=v8:5495
==========

[Benedikt Meurer, 2017-01-12 15:08:35]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2017-01-12 15:08:36]

LGTM on compiler.

[Jakob Kummerow, 2017-01-12 15:40:31]

LGTM with a question and two suggestions, all of which you can ignore.

https://codereview.chromium.org/2624903003/diff/1/src/factory.cc
File src/factory.cc (right):

https://codereview.chromium.org/2624903003/diff/1/src/factory.cc#newcode1774
src/factory.cc:1774: PropertyDetails d(details.attributes(), ACCESSOR_CONSTANT,
i + 1,
Doesn't this constructor get updated too?

https://codereview.chromium.org/2624903003/diff/1/src/json-stringifier.cc
File src/json-stringifier.cc (right):

https://codereview.chromium.org/2624903003/diff/1/src/json-stringifier.cc#new...
src/json-stringifier.cc:537: if (details.location() == kField && *map ==
js_obj->map()) {
DCHECK_EQ(kData, details.kind());

https://codereview.chromium.org/2624903003/diff/1/src/lookup.cc
File src/lookup.cc (right):

https://codereview.chromium.org/2624903003/diff/1/src/lookup.cc#newcode596
src/lookup.cc:596: } else if (property_details_.location() == kField) {
DCHECK_EQ(kData, details.kind());

[Igor Sheludko, 2017-01-12 15:52:31]

Thanks, landing.

https://codereview.chromium.org/2624903003/diff/1/src/factory.cc
File src/factory.cc (right):

https://codereview.chromium.org/2624903003/diff/1/src/factory.cc#newcode1774
src/factory.cc:1774: PropertyDetails d(details.attributes(), ACCESSOR_CONSTANT,
i + 1,
On 2017/01/12 15:40:30, Jakob Kummerow wrote:
> Doesn't this constructor get updated too?

Right. I'll update the PropertyDetails constructors in a follow-up CL.

https://codereview.chromium.org/2624903003/diff/1/src/json-stringifier.cc
File src/json-stringifier.cc (right):

https://codereview.chromium.org/2624903003/diff/1/src/json-stringifier.cc#new...
src/json-stringifier.cc:537: if (details.location() == kField && *map ==
js_obj->map()) {
On 2017/01/12 15:40:30, Jakob Kummerow wrote:
> DCHECK_EQ(kData, details.kind());

Done.

https://codereview.chromium.org/2624903003/diff/1/src/lookup.cc
File src/lookup.cc (right):

https://codereview.chromium.org/2624903003/diff/1/src/lookup.cc#newcode596
src/lookup.cc:596: } else if (property_details_.location() == kField) {
On 2017/01/12 15:40:30, Jakob Kummerow wrote:
> DCHECK_EQ(kData, details.kind());

Done.

[Igor Sheludko, 2017-01-12 15:55:06]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2017-01-12 15:55:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2624903003/#ps100001
(title: "Addressing comments")

[commit-bot: I haz the power, 2017-01-12 15:55:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 16:37:13]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484236506602610,
"parent_rev": "778cf612dc54459be3831fd2b6f8e8d365c98b5f", "commit_rev":
"d3d57ebaf6cd7084892aae37c3e54293c07b65b8"}

[commit-bot: I haz the power, 2017-01-12 16:37:18]

Description was changed from

==========
[runtime] Use PropertyKind/PropertyLocation instead of PropertyType.

This is a necessary cleanup before introducing PropertyConstness bit.

BUG=v8:5495
==========

to

==========
[runtime] Use PropertyKind/PropertyLocation instead of PropertyType.

This is a necessary cleanup before introducing PropertyConstness bit.

BUG=v8:5495

Review-Url: https://codereview.chromium.org/2624903003
Cr-Commit-Position: refs/heads/master@{#42277}
Committed:
https://chromium.googlesource.com/v8/v8/+/d3d57ebaf6cd7084892aae37c3e54293c07...
==========

[commit-bot: I haz the power, 2017-01-12 16:37:19]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/d3d57ebaf6cd7084892aae37c3e54293c07...