Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 2626993002: Speculatively clobber Mac after "Switch Mac Intel GPU bots to 10.12 from 10.10" (Closed)

Created:
3 years, 11 months ago by foolip
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Speculatively clobber Mac after "Switch Mac Intel GPU bots to 10.12 from 10.10" Something in this range broke the Mac builder: https://chromium.googlesource.com/chromium/src/+log/c6e4c6f1f9865b5a77d2cc4eb8c7104b632624f1%5E..1a7740c44a6c4d03423c4b5ff7d746e1a1b7363e?pretty=fuller r442828 is the most obvious candidate which may have affected builds. BUG=679607 TBR=kbr@chromium.org Review-Url: https://codereview.chromium.org/2626993002 . Cr-Commit-Position: refs/heads/master@{#442832} Committed: https://chromium.googlesource.com/chromium/src/+/117c52b0a0add3b82ca354e6a2d3dd2be54abc25

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/get_landmines.py View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (2 generated)
foolip
Committed patchset #1 (id:1) manually as 117c52b0a0add3b82ca354e6a2d3dd2be54abc25 (tree was closed).
3 years, 11 months ago (2017-01-11 09:26:31 UTC) #2
Nico
3 years, 9 months ago (2017-03-02 18:27:46 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/2626993002/diff/1/build/get_landmines.py
File build/get_landmines.py (right):

https://codereview.chromium.org/2626993002/diff/1/build/get_landmines.py#newc...
build/get_landmines.py:26: # DO NOT add landmines as part of a regular CL.
Landmines are a last-effort
have you seen this comment? was there an investigation for the root cause for
why this clobber was necessary? why wasn't this reviewed?

Powered by Google App Engine
This is Rietveld 408576698