Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: build/get_landmines.py

Issue 2626993002: Speculatively clobber Mac after "Switch Mac Intel GPU bots to 10.12 from 10.10" (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2013 The Chromium Authors. All rights reserved. 2 # Copyright 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ 6 """
7 This file emits the list of reasons why a particular build needs to be clobbered 7 This file emits the list of reasons why a particular build needs to be clobbered
8 (or a list of 'landmines'). 8 (or a list of 'landmines').
9 """ 9 """
10 10
11 import sys 11 import sys
12 12
13 import landmine_utils 13 import landmine_utils
14 14
15 15
16 distributor = landmine_utils.distributor 16 distributor = landmine_utils.distributor
17 gyp_defines = landmine_utils.gyp_defines 17 gyp_defines = landmine_utils.gyp_defines
18 gyp_msvs_version = landmine_utils.gyp_msvs_version 18 gyp_msvs_version = landmine_utils.gyp_msvs_version
19 platform = landmine_utils.platform 19 platform = landmine_utils.platform
20 20
21 21
22 def print_landmines(): 22 def print_landmines():
23 """ 23 """
24 ALL LANDMINES ARE EMITTED FROM HERE. 24 ALL LANDMINES ARE EMITTED FROM HERE.
25 """ 25 """
26 # DO NOT add landmines as part of a regular CL. Landmines are a last-effort 26 # DO NOT add landmines as part of a regular CL. Landmines are a last-effort
Nico 2017/03/02 18:27:46 have you seen this comment? was there an investiga
27 # bandaid fix if a CL that got landed has a build dependency bug and all bots 27 # bandaid fix if a CL that got landed has a build dependency bug and all bots
28 # need to be cleaned up. If you're writing a new CL that causes build 28 # need to be cleaned up. If you're writing a new CL that causes build
29 # dependency problems, fix the dependency problems instead of adding a 29 # dependency problems, fix the dependency problems instead of adding a
30 # landmine. 30 # landmine.
31 31
32 if distributor() == 'goma' and platform() == 'win32': 32 if distributor() == 'goma' and platform() == 'win32':
33 print 'Need to clobber winja goma due to backend cwd cache fix.' 33 print 'Need to clobber winja goma due to backend cwd cache fix.'
34 if platform() == 'android': 34 if platform() == 'android':
35 print 'Clobber: to handle new way of suppressing findbugs failures.' 35 print 'Clobber: to handle new way of suppressing findbugs failures.'
36 print 'Clobber to fix gyp not rename package name (crbug.com/457038)' 36 print 'Clobber to fix gyp not rename package name (crbug.com/457038)'
(...skipping 26 matching lines...) Expand all
63 if platform() == 'ios': 63 if platform() == 'ios':
64 print 'Clobber iOS to workaround Xcode deps bug (crbug.com/485435)' 64 print 'Clobber iOS to workaround Xcode deps bug (crbug.com/485435)'
65 if platform() == 'win': 65 if platform() == 'win':
66 print 'Clobber to delete stale generated files (crbug.com/510086)' 66 print 'Clobber to delete stale generated files (crbug.com/510086)'
67 if platform() == 'android' and gyp_defines().get('target_arch') == 'arm64': 67 if platform() == 'android' and gyp_defines().get('target_arch') == 'arm64':
68 print 'Clobber to support new location/infra for chrome_sync_shell_apk' 68 print 'Clobber to support new location/infra for chrome_sync_shell_apk'
69 if platform() == 'mac': 69 if platform() == 'mac':
70 print 'Clobber to get rid of evil libsqlite3.dylib (crbug.com/526208)' 70 print 'Clobber to get rid of evil libsqlite3.dylib (crbug.com/526208)'
71 if platform() == 'mac': 71 if platform() == 'mac':
72 print 'Clobber to remove libsystem.dylib. See crbug.com/620075' 72 print 'Clobber to remove libsystem.dylib. See crbug.com/620075'
73 if platform() == 'mac':
74 print 'Clobber to get past mojo gen build error (crbug.com/679607)'
73 75
74 76
75 def main(): 77 def main():
76 print_landmines() 78 print_landmines()
77 return 0 79 return 0
78 80
79 81
80 if __name__ == '__main__': 82 if __name__ == '__main__':
81 sys.exit(main()) 83 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698