Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 2626953003: Reland of [wasm][asm.js] Do same work even when not printing asm info. (Closed)

Created:
3 years, 11 months ago by bradnelson
Modified:
3 years, 11 months ago
Reviewers:
bradn, danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [wasm][asm.js] Do same work even when not printing asm info. (patchset #1 id:1 of https://codereview.chromium.org/2627223002/ ) Reason for revert: Triggers flaky tests. Original issue's description: > Revert of [wasm][asm.js] Do same work even when not printing asm info. (patchset #1 id:1 of https://codereview.chromium.org/2629043002/ ) > > Reason for revert: > Triggers flaky tests. > > Original issue's description: > > [wasm][asm.js] Do same work even when not printing asm info. > > > > Skipping this work seems to perturb a gc-stress issue. > > More investigation is likely needed. > > > > BUG=v8:4203 > > R=danno@chromium.org > > > > Review-Url: https://codereview.chromium.org/2629043002 > > Cr-Commit-Position: refs/heads/master@{#42248} > > Committed: https://chromium.googlesource.com/v8/v8/+/785cedf1ee6671399c2b2b7f6c6a8119f55195b4 > > TBR=danno@chromium.org,bradnelson@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4203 > > Review-Url: https://codereview.chromium.org/2627223002 > Cr-Commit-Position: refs/heads/master@{#42250} > Committed: https://chromium.googlesource.com/v8/v8/+/636df54873c966eceed4264cabc2360b76221e26 TBR=danno@chromium.org,bradnelson@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4203 Review-Url: https://codereview.chromium.org/2626953003 Cr-Commit-Position: refs/heads/master@{#42251} Committed: https://chromium.googlesource.com/v8/v8/+/bd7fed19713f020e908a5e273e324439fed485fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -41 lines) Patch
M src/asmjs/asm-js.cc View 2 chunks +34 lines, -41 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
bradnelson
Created Reland of [wasm][asm.js] Do same work even when not printing asm info.
3 years, 11 months ago (2017-01-12 01:57:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626953003/1
3 years, 11 months ago (2017-01-12 01:57:21 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 01:58:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/bd7fed19713f020e908a5e273e324439fed...

Powered by Google App Engine
This is Rietveld 408576698