Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Issue 2629043002: [wasm][asm.js] Do same work even when not printing asm info. (Closed)

Created:
3 years, 11 months ago by bradnelson
Modified:
3 years, 11 months ago
Reviewers:
bradn, danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Do same work even when not printing asm info. Skipping this work seems to perturb a gc-stress issue. More investigation is likely needed. BUG=v8:4203 R=danno@chromium.org Review-Url: https://codereview.chromium.org/2629043002 Cr-Commit-Position: refs/heads/master@{#42248} Committed: https://chromium.googlesource.com/v8/v8/+/785cedf1ee6671399c2b2b7f6c6a8119f55195b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -41 lines) Patch
M src/asmjs/asm-js.cc View 2 chunks +34 lines, -41 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
bradn
3 years, 11 months ago (2017-01-12 00:40:49 UTC) #4
danno
lgtm
3 years, 11 months ago (2017-01-12 00:48:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629043002/1
3 years, 11 months ago (2017-01-12 00:48:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/785cedf1ee6671399c2b2b7f6c6a8119f55195b4
3 years, 11 months ago (2017-01-12 01:08:04 UTC) #11
bradn
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2627223002/ by bradnelson@google.com. ...
3 years, 11 months ago (2017-01-12 01:55:45 UTC) #12
bradnelson
3 years, 11 months ago (2017-01-12 01:58:29 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2623383002/ by bradnelson@chromium.org.

The reason for reverting is: Triggers flaky tests..

Powered by Google App Engine
This is Rietveld 408576698