Make Editor::appliedEditing update layout before changing selection

Make Editor::appliedEditing update layout before changing selection

Updating frame selection currently requires clean layout, as it calls
mostBackwardCaretPosition through SelectionAdjuster. One code path that
violates it is from Editor::appliedEditing, which is fixed by this patch.

BUG=679616
Review-Url: https://codereview.chromium.org/2626933002
Cr-Commit-Position: refs/heads/master@{#442881}
Committed: https://chromium.googlesource.com/chromium/src/+/c9297ecbd87ae09ce5f315c0ae5718cf9a4aabf0

[Xiaocheng, 2017-01-11 02:45:53]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:46:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-01-11 03:35:02]

yosin@chromium.org changed reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2017-01-11 03:35:02]

lgtm

Could you also add |DCHECK()| for clean layout to
|mose{Back,For}wardCaretPosition()| in another patch?

[Xiaocheng, 2017-01-11 05:00:42]

On 2017/01/11 at 03:35:02, yosin wrote:
> lgtm
> 
> Could you also add |DCHECK()| for clean layout to
|mose{Back,For}wardCaretPosition()| in another patch?

Unfortunately we can't do that right now...

See the experiment results here: https://codereview.chromium.org/2623103003

Also see your notes in computeSelectionType():
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/V...

[Xiaocheng, 2017-01-11 05:08:18]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 05:08:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-01-11 06:12:30]

The CQ bit was unchecked by xiaochengh@chromium.org

[Xiaocheng, 2017-01-11 06:12:32]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2017-01-11 06:12:33]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2626933002/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2017-01-11 06:12:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-01-11 06:31:43]

On 2017/01/11 at 05:00:42, xiaochengh wrote:
> On 2017/01/11 at 03:35:02, yosin wrote:
> > lgtm
> > 
> > Could you also add |DCHECK()| for clean layout to
|mose{Back,For}wardCaretPosition()| in another patch?
> 
> Unfortunately we can't do that right now...
> 
> See the experiment results here: https://codereview.chromium.org/2623103003
> 
> Also see your notes in computeSelectionType():
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/V...

Thank you for investigation.
I handle this, http://crbug.com/679991

[commit-bot: I haz the power, 2017-01-11 07:19:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 07:19:56]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Xiaocheng, 2017-01-11 07:22:55]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2017-01-11 07:23:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 08:35:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 08:35:13]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Xiaocheng, 2017-01-11 11:52:28]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2017-01-11 11:52:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 12:26:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484135548297790,
"parent_rev": "ce6ec84a84d649f1792d4ef52b611050bba468d4", "commit_rev":
"c9297ecbd87ae09ce5f315c0ae5718cf9a4aabf0"}

[commit-bot: I haz the power, 2017-01-11 12:27:01]

Description was changed from

==========
Make Editor::appliedEditing update layout before changing selection

Updating frame selection currently requires clean layout, as it calls
mostBackwardCaretPosition through SelectionAdjuster. One code path that
violates it is from Editor::appliedEditing, which is fixed by this patch.

BUG=679616
==========

to

==========
Make Editor::appliedEditing update layout before changing selection

Updating frame selection currently requires clean layout, as it calls
mostBackwardCaretPosition through SelectionAdjuster. One code path that
violates it is from Editor::appliedEditing, which is fixed by this patch.

BUG=679616

Review-Url: https://codereview.chromium.org/2626933002
Cr-Commit-Position: refs/heads/master@{#442881}
Committed:
https://chromium.googlesource.com/chromium/src/+/c9297ecbd87ae09ce5f315c0ae57...
==========

[commit-bot: I haz the power, 2017-01-11 12:27:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c9297ecbd87ae09ce5f315c0ae57...