Convert editing/pasteboard/5075944.html with assert_selection

Convert editing/pasteboard/5075944.html with assert_selection

This patch converts editing/pasteboard/5075944.html with assert_selection
to promote the use of w3c testharness and improve code health.

It is also a preparation for https://codereview.chromium.org/2626933002

BUG=679616, 679977
Review-Url: https://codereview.chromium.org/2621213002
Cr-Commit-Position: refs/heads/master@{#442820}
Committed: https://chromium.googlesource.com/chromium/src/+/a0873eea705ea81161ec71eb3055001920f7b448

[Xiaocheng, 2017-01-11 02:25:47]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:26:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-01-11 02:27:31]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:27:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-01-11 02:46:12]

Description was changed from

==========
Convert editing/pasteboard/5075944.html with assert_selection

BUG=
==========

to

==========
Convert editing/pasteboard/5075944.html with assert_selection

This patch converts editing/pasteboard/5075944.html with assert_selection
to promote the use of w3c testharness and improve code health.

It is also a preparation for https://codereview.chromium.org/2626933002

BUG=
==========

[Xiaocheng, 2017-01-11 02:46:46]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-01-11 02:46:47]

PTAL.

Btw, what's the bug number for tracking such layout test conversions?

[yosin_UTC9, 2017-01-11 03:37:46]

On 2017/01/11 at 02:46:47, xiaochengh wrote:
> PTAL.
> 
> Btw, what's the bug number for tracking such layout test conversions?

http://crbug.com/679977

So far, it is part of "lazy selection", but situation is changed. 
Usefulness of |assert_selection()| is proved.

[yosin_UTC9, 2017-01-11 03:40:05]

https://codereview.chromium.org/2621213002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/pasteboard/copy-paste-underlined.html
(right):

https://codereview.chromium.org/2621213002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/pasteboard/copy-paste-underlined.html:14:
document.execCommand('copy');
Since this test doesn't work with interactive session due by "copy" and "paste".
Please check availability of |window.testRunner|, like

assert_not_equals(window.testRunner, undefined, 'This test requires
testRunner.');

[commit-bot: I haz the power, 2017-01-11 03:45:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 03:45:14]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-01-11 05:02:00]

Description was changed from

==========
Convert editing/pasteboard/5075944.html with assert_selection

This patch converts editing/pasteboard/5075944.html with assert_selection
to promote the use of w3c testharness and improve code health.

It is also a preparation for https://codereview.chromium.org/2626933002

BUG=
==========

to

==========
Convert editing/pasteboard/5075944.html with assert_selection

This patch converts editing/pasteboard/5075944.html with assert_selection
to promote the use of w3c testharness and improve code health.

It is also a preparation for https://codereview.chromium.org/2626933002

BUG=679616, 679977
==========

[Xiaocheng, 2017-01-11 05:03:54]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 05:04:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-01-11 05:07:44]

Thanks for the review!

https://codereview.chromium.org/2621213002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/pasteboard/copy-paste-underlined.html
(right):

https://codereview.chromium.org/2621213002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/pasteboard/copy-paste-underlined.html:14:
document.execCommand('copy');
On 2017/01/11 at 03:40:05, Yosi_UTC9 wrote:
> Since this test doesn't work with interactive session due by "copy" and
"paste".
> Please check availability of |window.testRunner|, like
> 
> assert_not_equals(window.testRunner, undefined, 'This test requires
testRunner.');

Done.

[yosin_UTC9, 2017-01-11 05:53:15]

lgtm

BTW, another pattern for checking |window.testRunner| is

test(() => {
  if (!window.testRunner) [
    assert_not_reached('This test requires testRunner.');
    return;
  }
  ... testRunner dependent code ...
});

This pattern reduces failure output. But it requires one more line.

[commit-bot: I haz the power, 2017-01-11 06:03:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 06:03:04]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-01-11 06:05:15]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2017-01-11 06:05:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 06:10:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484114715580380,
"parent_rev": "293f4eecd49dd62088f2ba3e12c3fc17eb5e43fd", "commit_rev":
"a0873eea705ea81161ec71eb3055001920f7b448"}

[commit-bot: I haz the power, 2017-01-11 06:11:15]

Description was changed from

==========
Convert editing/pasteboard/5075944.html with assert_selection

This patch converts editing/pasteboard/5075944.html with assert_selection
to promote the use of w3c testharness and improve code health.

It is also a preparation for https://codereview.chromium.org/2626933002

BUG=679616, 679977
==========

to

==========
Convert editing/pasteboard/5075944.html with assert_selection

This patch converts editing/pasteboard/5075944.html with assert_selection
to promote the use of w3c testharness and improve code health.

It is also a preparation for https://codereview.chromium.org/2626933002

BUG=679616, 679977

Review-Url: https://codereview.chromium.org/2621213002
Cr-Commit-Position: refs/heads/master@{#442820}
Committed:
https://chromium.googlesource.com/chromium/src/+/a0873eea705ea81161ec71eb3055...
==========

[commit-bot: I haz the power, 2017-01-11 06:11:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a0873eea705ea81161ec71eb3055...