src/ic/ic.cc - Issue 2626893005: Revert of Internalize strings in-place

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic.cc

Issue 2626893005: Revert of Internalize strings in-place (Closed)

Patch Set: rebased Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/ic.cc

diff --git a/src/ic/ic.cc b/src/ic/ic.cc

index 6cd1641ade3f3d15f7898ed611f154ddae0e94db..c29100ab3fae5cf4c3a758ea455b9cd004054789 100644

--- a/src/ic/ic.cc

+++ b/src/ic/ic.cc

@@ -1578,8 +1578,6 @@ static Handle<Object> TryConvertKey(Handle<Object> key, Isolate* isolate) {

}

} else if (key->IsUndefined(isolate)) {

key = isolate->factory()->undefined_string();

- } else if (key->IsString()) {

- key = isolate->factory()->InternalizeString(Handle<String>::cast(key));

}

return key;

}

« no previous file with comments | « src/ic/accessor-assembler.cc ('k') | src/ic/keyed-store-generic.cc » ('j') | no next file with comments »