Don't put timers with ID == 0 into the global timer map.

Don't put timers with ID == 0 into the global timer map.

A return of ID == 0 from the embedder means the timer was not
created (see public/fpdf_formfill.h), although few embedders
actually conform to this convention.

Firing a timer with ID == 0 will thus do nothing since there can't
be such a timer in the map.

BUG=679649
Review-Url: https://codereview.chromium.org/2626863003
Committed: https://pdfium.googlesource.com/pdfium/+/6cf5ecae75a5cd6fea9ae7f4e28cc28abb3e69c6

[Tom Sepez, 2017-01-11 22:50:37]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 22:50:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2017-01-11 22:51:12]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2017-01-11 22:51:12]

Dan, for review.

[Tom Sepez, 2017-01-11 22:53:48]

Description was changed from

==========
Don't put timers with ID == 0 into the global timer map.

A return of ID == 0 from the embedder means the timer was not
created (see public/fpdf_formfill.h), although few embedders
actually conform to this convention.

Firing a timer with ID == 0 will thus do nothing since there can't
be such a timer in the map.

BUG=679642
==========

to

==========
Don't put timers with ID == 0 into the global timer map.

A return of ID == 0 from the embedder means the timer was not
created (see public/fpdf_formfill.h), although few embedders
actually conform to this convention.

Firing a timer with ID == 0 will thus do nothing since there can't
be such a timer in the map.

BUG=679649
==========

[commit-bot: I haz the power, 2017-01-11 23:06:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 23:06:04]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2017-01-12 14:30:16]

Is there a test we should add around this so it doesn't regress?

[Tom Sepez, 2017-01-12 19:03:27]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 19:03:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2017-01-12 19:04:16]

On 2017/01/12 14:30:16, dsinclair wrote:
> Is there a test we should add around this so it doesn't regress?
Done.  Confirmed the testcase trips asan without patch.

[dsinclair, 2017-01-12 19:12:07]

lgtm

[Tom Sepez, 2017-01-12 19:20:27]

The CQ bit was unchecked by tsepez@chromium.org

[Tom Sepez, 2017-01-12 19:20:31]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2017-01-12 19:20:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 19:21:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484248831185750,
"parent_rev": "192497124e7cde747ade7bf89028586eea293be5", "commit_rev":
"6cf5ecae75a5cd6fea9ae7f4e28cc28abb3e69c6"}

[commit-bot: I haz the power, 2017-01-12 19:21:16]

Description was changed from

==========
Don't put timers with ID == 0 into the global timer map.

A return of ID == 0 from the embedder means the timer was not
created (see public/fpdf_formfill.h), although few embedders
actually conform to this convention.

Firing a timer with ID == 0 will thus do nothing since there can't
be such a timer in the map.

BUG=679649
==========

to

==========
Don't put timers with ID == 0 into the global timer map.

A return of ID == 0 from the embedder means the timer was not
created (see public/fpdf_formfill.h), although few embedders
actually conform to this convention.

Firing a timer with ID == 0 will thus do nothing since there can't
be such a timer in the map.

BUG=679649

Review-Url: https://codereview.chromium.org/2626863003
Committed:
https://pdfium.googlesource.com/pdfium/+/6cf5ecae75a5cd6fea9ae7f4e28cc28abb3e...
==========

[commit-bot: I haz the power, 2017-01-12 19:21:17]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/6cf5ecae75a5cd6fea9ae7f4e28cc28abb3e...