fpdfsdk/javascript/app.cpp - Issue 2626863003: Don't put timers with ID == 0 into the global timer map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/app.cpp

Issue 2626863003: Don't put timers with ID == 0 into the global timer map. (Closed)

Patch Set: add test Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/app.cpp

diff --git a/fpdfsdk/javascript/app.cpp b/fpdfsdk/javascript/app.cpp

index 80c952d6cac03d367db3ecde6d42fdc6c2e5bcfc..6562d1b5985f0695cce4a9b3f7e08e08d9487bc0 100644

--- a/fpdfsdk/javascript/app.cpp

+++ b/fpdfsdk/javascript/app.cpp

@@ -75,7 +75,8 @@ GlobalTimer::GlobalTimer(app* pObj,

m_pFormFillEnv(pFormFillEnv) {

CFX_SystemHandler* pHandler = m_pFormFillEnv->GetSysHandler();

m_nTimerID = pHandler->SetTimer(dwElapse, Trigger);

- (*GetGlobalTimerMap())[m_nTimerID] = this;

+ if (m_nTimerID)

+ (*GetGlobalTimerMap())[m_nTimerID] = this;

}

GlobalTimer::~GlobalTimer() {