The great shader refactor: Separate initialization from ctor

The great shader refactor: Separate initialization from ctor

This moves initialization of parameters to SetSubclassProperties.
The next step is to clean up initialization to use a common program
descriptor. In that patch, I'll change these functions to
CheckSubclassProperties, so that I can DCHECK that I didn't change
anything.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2626823002
Cr-Commit-Position: refs/heads/master@{#442761}
Committed: https://chromium.googlesource.com/chromium/src/+/a94e1212122cbd16cab63f2d10ed9e8a74a8fe98

[ccameron, 2017-01-10 22:08:09]

Description was changed from

==========
The great shader refactor: Separate initialization from ctor

This does some cleanup so that deleting the shader sub-classes is
more likely to not have errors.

BUG=667966
==========

to

==========
The great shader refactor: Separate initialization from ctor

This does some cleanup so that deleting the shader sub-classes is
more likely to not have errors.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-01-10 22:08:22]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 22:09:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 23:33:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 23:33:20]

Dry run: This issue passed the CQ dry run.

[ccameron, 2017-01-11 00:01:41]

Description was changed from

==========
The great shader refactor: Separate initialization from ctor

This does some cleanup so that deleting the shader sub-classes is
more likely to not have errors.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
The great shader refactor: Separate initialization from ctor

This moves initialization of parameters to SetSubclassProperties.
The next step is to clean up initialization to use a common program
descriptor. In that patch, I'll change these functions to
CheckSubclassProperties, so that I can DCHECK that I didn't change
anything.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-01-11 00:01:42]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org

[ccameron, 2017-01-11 00:01:59]

ptal -- small patch.

[enne (OOO), 2017-01-11 01:28:46]

lgtm

[ccameron, 2017-01-11 01:32:30]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-01-11 01:33:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 01:37:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484098350451290, "parent_rev":
"c9f9c596f4d35ec6d14ff78f8be7a08bfc989041", "commit_rev":
"a94e1212122cbd16cab63f2d10ed9e8a74a8fe98"}

[commit-bot: I haz the power, 2017-01-11 01:38:28]

Description was changed from

==========
The great shader refactor: Separate initialization from ctor

This moves initialization of parameters to SetSubclassProperties.
The next step is to clean up initialization to use a common program
descriptor. In that patch, I'll change these functions to
CheckSubclassProperties, so that I can DCHECK that I didn't change
anything.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
The great shader refactor: Separate initialization from ctor

This moves initialization of parameters to SetSubclassProperties.
The next step is to clean up initialization to use a common program
descriptor. In that patch, I'll change these functions to
CheckSubclassProperties, so that I can DCHECK that I didn't change
anything.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2626823002
Cr-Commit-Position: refs/heads/master@{#442761}
Committed:
https://chromium.googlesource.com/chromium/src/+/a94e1212122cbd16cab63f2d10ed...
==========

[commit-bot: I haz the power, 2017-01-11 01:38:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a94e1212122cbd16cab63f2d10ed...