The great shader refactor: Separate initialization from ctor

cc/output/program_binding.h

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_OUTPUT_PROGRAM_BINDING_H_
 #define CC_OUTPUT_PROGRAM_BINDING_H_
 
 #include <string>
 
 #include "base/logging.h"
@@ skipping 44 matching lines @@
 };
 
 template <class VertexShader, class FragmentShader>
 class ProgramBinding : public ProgramBindingBase {
  public:
   ProgramBinding() {}
 
   void Initialize(ContextProvider* context_provider,
                   TexCoordPrecision precision,
                   SamplerType sampler) {
-    return Initialize(
-        context_provider, precision, sampler, BLEND_MODE_NONE, false);
+    Initialize(context_provider, precision, sampler, BLEND_MODE_NONE, false);
   }
 
   void Initialize(ContextProvider* context_provider,
                   TexCoordPrecision precision,
                   SamplerType sampler,
                   BlendMode blend_mode) {
-    return Initialize(
-        context_provider, precision, sampler, blend_mode, false);
+    Initialize(context_provider, precision, sampler, blend_mode, false);
+  }
+
+  void InitializeVideoYUV(ContextProvider* context_provider,
+                          TexCoordPrecision precision,
+                          SamplerType sampler,
+                          bool use_alpha_plane,
+                          bool use_nv12,
+                          bool use_color_lut) {
+    fragment_shader_.use_alpha_texture_ = use_alpha_plane;
+    fragment_shader_.use_nv12_ = use_nv12;
+    fragment_shader_.use_color_lut_ = use_color_lut;
+    Initialize(context_provider, precision, sampler);
   }
 
   void Initialize(ContextProvider* context_provider,
                   TexCoordPrecision precision,
                   SamplerType sampler,
                   BlendMode blend_mode,
                   bool mask_for_background) {
+    vertex_shader_.SetSubclassProperties();
+    fragment_shader_.SetSubclassProperties();
+    fragment_shader_.blend_mode_ = blend_mode;
+    fragment_shader_.mask_for_background_ = mask_for_background;
+    fragment_shader_.tex_coord_precision_ = precision;
+    fragment_shader_.sampler_type_ = sampler;
+    InitializeInternal(context_provider);
+  }
+
+  const VertexShader& vertex_shader() const { return vertex_shader_; }
+  const FragmentShader& fragment_shader() const { return fragment_shader_; }
+
+ private:
+  void InitializeInternal(ContextProvider* context_provider) {
     DCHECK(context_provider);
     DCHECK(!initialized_);
 
     if (IsContextLost(context_provider->ContextGL()))
       return;
 
-    fragment_shader_.set_blend_mode(blend_mode);
-    fragment_shader_.set_mask_for_background(mask_for_background);
-
-    if (!ProgramBindingBase::Init(
-            context_provider->ContextGL(),
-            vertex_shader_.GetShaderString(),
-            fragment_shader_.GetShaderString(precision, sampler))) {
+    if (!ProgramBindingBase::Init(context_provider->ContextGL(),
+                                  vertex_shader_.GetShaderString(),
+                                  fragment_shader_.GetShaderString())) {
       DCHECK(IsContextLost(context_provider->ContextGL()));
       return;
     }
 
     int base_uniform_index = 0;
     vertex_shader_.Init(context_provider->ContextGL(),
                         program_, &base_uniform_index);
     fragment_shader_.Init(context_provider->ContextGL(),
                           program_, &base_uniform_index);
 
     // Link after binding uniforms
     if (!Link(context_provider->ContextGL())) {
       DCHECK(IsContextLost(context_provider->ContextGL()));
       return;
     }
 
     initialized_ = true;
   }
 
-  const VertexShader& vertex_shader() const { return vertex_shader_; }
-  const FragmentShader& fragment_shader() const { return fragment_shader_; }
-  FragmentShader* mutable_fragment_shader() { return &fragment_shader_; }
-
- private:
   VertexShader vertex_shader_;
   FragmentShader fragment_shader_;
 
   DISALLOW_COPY_AND_ASSIGN(ProgramBinding);
 };
 
 }  // namespace cc
 
 #endif  // CC_OUTPUT_PROGRAM_BINDING_H_