Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2626733003: [ios] Removed -[CRWWebDelegate webDidAddPendingURL]. (Closed)

Created:
3 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed -[CRWWebDelegate webDidAddPendingURL]. Use webState:didStartProvisionalNavigationForURL: instead. BUG=674991 Review-Url: https://codereview.chromium.org/2626733003 Cr-Commit-Position: refs/heads/master@{#443247} Committed: https://chromium.googlesource.com/chromium/src/+/ff1de2a101c43ec975180b26fbe320899c4fc4f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/tabs/tab_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/public/web_state/ui/crw_web_delegate.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Eugene But (OOO till 7-30)
3 years, 11 months ago (2017-01-12 02:35:38 UTC) #6
marq (ping after 24h)
lgtm
3 years, 11 months ago (2017-01-12 15:25:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626733003/1
3 years, 11 months ago (2017-01-12 15:56:48 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 16:10:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ff1de2a101c43ec975180b26fbe3...

Powered by Google App Engine
This is Rietveld 408576698