ios/chrome/browser/tabs/tab_unittest.mm - Issue 2626733003: [ios] Removed -[CRWWebDelegate webDidAddPendingURL].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/tabs/tab_unittest.mm

Issue 2626733003: [ios] Removed -[CRWWebDelegate webDidAddPendingURL]. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/tabs/tab_unittest.mm

diff --git a/ios/chrome/browser/tabs/tab_unittest.mm b/ios/chrome/browser/tabs/tab_unittest.mm

index 2b495893831b8fa2e8adaab8391798c78c91c81c..9ae72de45bb161ad26be9f6c2a9fad297d254ec1 100644

--- a/ios/chrome/browser/tabs/tab_unittest.mm

+++ b/ios/chrome/browser/tabs/tab_unittest.mm

@@ -226,7 +226,7 @@ class TabTest : public BlockCleanupTest {

andReturnValue:OCMOCK_VALUE(kLoadRequested)] loadPhase];

web::Referrer empty_referrer;

[tab_ webWillAddPendingURL:userUrl transition:ui::PAGE_TRANSITION_TYPED];

- [tab_ webDidAddPendingURL];

+ [tab_ webStateImpl]->OnProvisionalNavigationStarted(userUrl);

[tab_ webWillAddPendingURL:redirectUrl

transition:ui::PAGE_TRANSITION_CLIENT_REDIRECT];

[[tab_ navigationManager]->GetSessionController()

@@ -234,7 +234,7 @@ class TabTest : public BlockCleanupTest {

referrer:empty_referrer

transition:ui::PAGE_TRANSITION_CLIENT_REDIRECT

rendererInitiated:YES];

- [tab_ webDidAddPendingURL];

+ [tab_ webStateImpl]->OnProvisionalNavigationStarted(redirectUrl);

[[[(id)mock_web_controller_ expect]

andReturnValue:OCMOCK_VALUE(kPageLoading)] loadPhase];

[[tab_ navigationManager]->GetSessionController() commitPendingEntry];

« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | ios/web/public/web_state/ui/crw_web_delegate.h » ('j') | no next file with comments »