MD Settings People: Fix ChromeOS Change Picture selected image bug

MD Settings People: Fix ChromeOS Change Picture selected image bug

Change Picture subpage can get into an odd state when the user navigates
away and then back again. This CL fixes that regression and adds a test.

BUG=674844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626733002
Cr-Commit-Position: refs/heads/master@{#442727}
Committed: https://chromium.googlesource.com/chromium/src/+/5846b9cf0505c478a930d79c3b6c96a264ee4e7d

[tommycli, 2017-01-10 20:25:55]

Description was changed from

==========
MD Settings People: Fix ChromeOS Change Picture selected image bug

Change Picture subpage can get into an odd state when the user navigates
away and then back again. This CL fixes that regression and adds a test.

BUG=674844
==========

to

==========
MD Settings People: Fix ChromeOS Change Picture selected image bug

Change Picture subpage can get into an odd state when the user navigates
away and then back again. This CL fixes that regression and adds a test.

BUG=674844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2017-01-10 20:26:20]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org, stevenjb@chromium.org

[tommycli, 2017-01-10 20:26:21]

stevenjb OR dbeam: PTAL, thanks!

[stevenjb, 2017-01-10 21:08:20]

lgtm

https://codereview.chromium.org/2626733002/diff/1/chrome/test/data/webui/sett...
File chrome/test/data/webui/settings/people_page_change_picture_test.js (right):

https://codereview.chromium.org/2626733002/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/people_page_change_picture_test.js:166:
changePicture.selectedItem_.dataset.type);
Fix indent

[tommycli, 2017-01-10 21:18:28]

thanks!

[tommycli, 2017-01-10 21:18:35]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-01-10 21:18:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2626733002/#ps20001
(title: "fix indent")

[commit-bot: I haz the power, 2017-01-10 21:19:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-01-10 21:47:26]

Description was changed from

==========
MD Settings People: Fix ChromeOS Change Picture selected image bug

Change Picture subpage can get into an odd state when the user navigates
away and then back again. This CL fixes that regression and adds a test.

BUG=674844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings People: Fix ChromeOS Change Picture selected image bug

Change Picture subpage can get into an odd state when the user navigates
away and then back again. This CL fixes that regression and adds a test.

BUG=674844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NO_DEPENDENCY_CHECKS=true
==========

[tommycli, 2017-01-10 21:47:32]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2017-01-10 21:47:32]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2017-01-10 21:47:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-01-10 21:47:49]

Description was changed from

==========
MD Settings People: Fix ChromeOS Change Picture selected image bug

Change Picture subpage can get into an odd state when the user navigates
away and then back again. This CL fixes that regression and adds a test.

BUG=674844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NO_DEPENDENCY_CHECKS=true
==========

to

==========
MD Settings People: Fix ChromeOS Change Picture selected image bug

Change Picture subpage can get into an odd state when the user navigates
away and then back again. This CL fixes that regression and adds a test.

BUG=674844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-01-10 22:48:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 22:48:14]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[tommycli, 2017-01-10 22:55:43]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2017-01-10 22:56:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 23:35:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484088943303780,
"parent_rev": "2d8a66165955cb54927f24e7ea53591a82177a99", "commit_rev":
"5846b9cf0505c478a930d79c3b6c96a264ee4e7d"}

[commit-bot: I haz the power, 2017-01-10 23:36:28]

Description was changed from

==========
MD Settings People: Fix ChromeOS Change Picture selected image bug

Change Picture subpage can get into an odd state when the user navigates
away and then back again. This CL fixes that regression and adds a test.

BUG=674844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings People: Fix ChromeOS Change Picture selected image bug

Change Picture subpage can get into an odd state when the user navigates
away and then back again. This CL fixes that regression and adds a test.

BUG=674844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626733002
Cr-Commit-Position: refs/heads/master@{#442727}
Committed:
https://chromium.googlesource.com/chromium/src/+/5846b9cf0505c478a930d79c3b6c...
==========

[commit-bot: I haz the power, 2017-01-10 23:36:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5846b9cf0505c478a930d79c3b6c...