Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2623993002:
MD Settings People: Fix ChromeOS Change Picture arrow keys (Closed)
|
Created:
3 years, 11 months ago by tommycli Modified:
3 years, 11 months ago Reviewers:
stevenjb CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings People: Fix ChromeOS Change Picture arrow keys
The arrow keys now actually select the newly highlighted picture.
BUG=668416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2623993002
Cr-Commit-Position: refs/heads/master@{#442795}
Committed: https://chromium.googlesource.com/chromium/src/+/6b13e1b5dfc1d83b733e6e6ec4d536a47feb8c7e
Patch Set 1 #Patch Set 2 : Merge branch 'master' of https://chromium.googlesource.com/chromium/src into 366-settings-fix-chang… #
Messages
Total messages: 27 (17 generated)
Description was changed from ========== MD Settings People: Fix ChromeOS Change Picture arrow keys The arrow keys now actually select the newly highlighted picture. BUG=668416 ========== to ========== MD Settings People: Fix ChromeOS Change Picture arrow keys The arrow keys now actually select the newly highlighted picture. BUG=668416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by tommycli@chromium.org to run a CQ dry run
tommycli@chromium.org changed reviewers: + stevenjb@chromium.org
stevenjb: PTAL, thanks!
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
On 2017/01/10 21:46:07, stevenjb wrote: > lgtm Thanks!
The CQ bit was unchecked by tommycli@chromium.org
The CQ bit was checked by tommycli@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2626733002 Patch 20001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Description was changed from ========== MD Settings People: Fix ChromeOS Change Picture arrow keys The arrow keys now actually select the newly highlighted picture. BUG=668416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings People: Fix ChromeOS Change Picture arrow keys The arrow keys now actually select the newly highlighted picture. BUG=668416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NO_DEPENDENCY_CHECKS=true ==========
The CQ bit was checked by tommycli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for
chrome/test/data/webui/settings/people_page_change_picture_test.js:
While running git apply --index -p1;
error: patch failed:
chrome/test/data/webui/settings/people_page_change_picture_test.js:201
error: chrome/test/data/webui/settings/people_page_change_picture_test.js:
patch does not apply
Patch: chrome/test/data/webui/settings/people_page_change_picture_test.js
Index: chrome/test/data/webui/settings/people_page_change_picture_test.js
diff --git a/chrome/test/data/webui/settings/people_page_change_picture_test.js
b/chrome/test/data/webui/settings/people_page_change_picture_test.js
index
acf646b6b3a45091e7770471d0403cc3e5289901..5a20bf976839a21b6a9bc3a78a0872a9fc947d84
100644
--- a/chrome/test/data/webui/settings/people_page_change_picture_test.js
+++ b/chrome/test/data/webui/settings/people_page_change_picture_test.js
@@ -201,6 +201,14 @@ cr.define('settings_people_page_change_picture', function()
{
expectEquals(firstDefaultImage, changePicture.selectedItem_);
expectFalse(settingsCamera.cameraActive);
expectTrue(discardControlBar.hidden);
+
+ // Now verify that arrow keys actually select the new image.
+ browserProxy.resetResolver('selectDefaultImage');
+ MockInteractions.pressAndReleaseKeyOn(
+ changePicture.selectedItem_, 39 /* right */);
+ return browserProxy.whenCalled('selectDefaultImage');
+ }).then(function(args) {
+ expectEquals('chrome://foo/2.png', args[0]);
});
});
The CQ bit was checked by tommycli@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stevenjb@chromium.org Link to the patchset: https://codereview.chromium.org/2623993002/#ps20001 (title: "Merge branch 'master' of https://chromium.googlesource.com/chromium/src into 366-settings-fix-chang…")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== MD Settings People: Fix ChromeOS Change Picture arrow keys The arrow keys now actually select the newly highlighted picture. BUG=668416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NO_DEPENDENCY_CHECKS=true ========== to ========== MD Settings People: Fix ChromeOS Change Picture arrow keys The arrow keys now actually select the newly highlighted picture. BUG=668416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by tommycli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484106326812510,
"parent_rev": "ca7cf349eaf2714ed766e67827486b8417aa84b7", "commit_rev":
"6b13e1b5dfc1d83b733e6e6ec4d536a47feb8c7e"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings People: Fix ChromeOS Change Picture arrow keys The arrow keys now actually select the newly highlighted picture. BUG=668416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings People: Fix ChromeOS Change Picture arrow keys The arrow keys now actually select the newly highlighted picture. BUG=668416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2623993002 Cr-Commit-Position: refs/heads/master@{#442795} Committed: https://chromium.googlesource.com/chromium/src/+/6b13e1b5dfc1d83b733e6e6ec4d5... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/6b13e1b5dfc1d83b733e6e6ec4d5... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
